282203 - partial commit erase remaining preedit strings

Status: RESOLVED EXPIRED

(Core :: Internationalization, defect)

Description

[Shinichi Hanaki]

User-Agent:       Mozilla/5.0 (X11; U; SunOS i86pc; ja-JP; rv:1.7) Gecko/20041216
Build Identifier: Mozilla/5.0 (X11; U; SunOS i86pc; ja-JP; rv:1.7) Gecko/20041216

The problem happens when I used Mozilla 1.7.5 for Solaris x86 in Solaris 9 under
the following condition:
locale: ja_JP.UTF-8
desktop: Gnome
IM: Atok12
then, type any Japanese characters on Composer, URL bar, search text field on
browser and try to partial commit,
remaining preedit strings disappear.

Reproducible: Always

Steps to Reproduce:
1. Login to Gnome in ja_JP.UTF-8 locale
2. Start mozilla and enter "AIUEO" in any text field(URL bar, search text field
etc.)
3. Try to commit partially "A" only and commit it by clicking "down arrow" key.


Actual Results:  
"A" is committed and then "IUEO" disappears until entering any key such as SPACE.

Expected Results:  
"A" is committed and "IUEO" should be displayed as uncommitted.

Japanese users often use partial commit especially in case of typing long text at
one time and then committing it per segment.

Comment 1

[Shinichi Hanaki]

When try to do partial commit in ja_JP.UTF-8 locale on Solaris9/Gnome
IM_preedit_changed_cb() and IM_commit_cb() is called in the following order.
1) IM_preedit_changed_cb() to erase full strings(AIUEO)
2) IM_preedit_changed_cb() to show "IUEO" as preedit strings
3) IM_commit_cb() to commit "A"
After 3), "IUEO" is erased.

On the other hand, when try to do the same step in ja locale,
different IM module is used.
Then, IM_preedit_changed_cb() and IM_commit_cb() is called in the following order.
1) IM_preedit_changed_cb() to erase full strings(AIUEO)
2) IM_commit_cb() to commit "A"
3) IM_preedit_changed_cb() to show "IUEO" as preedit strings
Then, partial commit works fine.

As a result of comparison these two cases,
the key is whether IM_commit_cb() is called before or after 2nd
IM_preedit_changed_cb() is called.　

In the case of "after", partial commit problem seems to happen.
 

Comment 2

[Shinichi Hanaki]

Attachment: suggested fix

I can't access to cvs repository.
So, I download the latest file and revise it, then make a diff from original
one.
I just inserted IM_preedit_changed_cb() at the end of IM_commit_cb()
to call preedit draw callback to check if remaining preedit strings exists.
I'm not sure, this is appropriate not only from a point of bug fix, but also
performance.
Anyway, I attached a patch as suggestion.

Comment 3

[Masaki Katakai]

Hanaki-san, could you put request for asking review to myself
([e-mail]) and super review to [e-mail].
You can put these by clicking "Edit" link at your patch.

Comment 4

[Shinichi Hanaki]

Comment on attachment 174344 [details] [diff] [review]
suggested fix

Katakai-san and Blizzard,
could you review this patch?

Comment 5

[Gervase Markham [:gerv]]

This is an automated message, with ID "auto-resolve01".

This bug has had no comments for a long time. Statistically, we have found that
bug reports that have not been confirmed by a second user after three months are
highly unlikely to be the source of a fix to the code.

While your input is very important to us, our resources are limited and so we
are asking for your help in focussing our efforts. If you can still reproduce
this problem in the latest version of the product (see below for how to obtain a
copy) or, for feature requests, if it's not present in the latest version and
you still believe we should implement it, please visit the URL of this bug
(given at the top of this mail) and add a comment to that effect, giving more
reproduction information if you have it.

If it is not a problem any longer, you need take no action. If this bug is not
changed in any way in the next two weeks, it will be automatically resolved.
Thank you for your help in this matter.

The latest beta releases can be obtained from:
Firefox:     http://www.mozilla.org/projects/firefox/
Thunderbird: http://www.mozilla.org/products/thunderbird/releases/1.5beta1.html
Seamonkey:   http://www.mozilla.org/projects/seamonkey/

Comment 6

[Gervase Markham [:gerv]]

This bug has been automatically resolved after a period of inactivity (see above
comment). If anyone thinks this is incorrect, they should feel free to reopen it.