282225 - bug in compilation of mozilla/mailnews/base/src/nsMessenger.cpp on sparc/solaris8

Status: RESOLVED INVALID

(SeaMonkey :: MailNews: Message Display, defect)

Description

[s.despret]

User-Agent:       Mozilla/5.0 (X11; U; SunOS sun4u; en-US; rv:1.8a5) Gecko/20041222
Build Identifier: Latest Mozilla/5.0 nightly

My compilations of last nightly stop with the following :

Building deps for nsMessenger.cpp
CC -o nsMessenger.o -c  -DMOZ_LDAP_XPCOM -DOSTYPE=\"SunOS5\" -DOSARCH=\"SunOS\"
-DHAVE_MOVEMAIL  -I../../../dist/include/xpcom
-I../../../dist/include/xpcom_obsolete -I../../../dist/include/string
-I../../../dist/include/necko -I../../../dist/include/dom
-I../../../dist/include/appshell -I../../../dist/include/toolkitcomps
-I../../../dist/include/appcomps -I../../../dist/include/uconv
-I../../../dist/include/intl -I../../../dist/include/htmlparser
-I../../../dist/include/widget -I../../../dist/include/docshell
-I../../../dist/include/rdf -I../../../dist/include/gfx
-I../../../dist/include/layout -I../../../dist/include/content
-I../../../dist/include/mailnews -I../../../dist/include/locale
-I../../../dist/include/unicharutil -I../../../dist/include/msgbaseutil
-I../../../dist/include/webshell -I../../../dist/include/txmgr
-I../../../dist/include/msgcompose -I../../../dist/include/msgdb
-I../../../dist/include/uriloader -I../../../dist/include/pref
-I../../../dist/include/msglocal -I../../../dist/include/msgimap
-I../../../dist/include/mork -I../../../dist/include/msgnews
-I../../../dist/include/addrbook -I../../../dist/include/mime
-I../../../dist/include/mimetype -I../../../dist/include/windowwatcher
-I../../../dist/include/webbrwsr -I../../../dist/include/exthandler
-I../../../dist/include/mozldap -I../../../dist/include/msgbase
-I../../../dist/include
-I/usr/local/mozilla/production/sources/mozilla/dist/include/nspr    
-I/usr/openwin/include     -I/usr/openwin/include -xlibmil -xlibmopt
-features=tmplife -norunpath -xbuiltin=%all -features=tmplife -mt  -DNDEBUG
-DTRIMMED -xO3  -I/usr/openwin/include -DMOZILLA_VERSION=\"1.8b\" -DSOLARIS=1
-DNSCAP_DISABLE_DEBUG_PTR_TYPES=1 -DD_INO=d_ino -DSTDC_HEADERS=1
-DHAVE_ST_BLKSIZE=1 -DHAVE_SIGINFO_T=1 -DHAVE_INT16_T=1 -DHAVE_INT32_T=1
-DHAVE_INT64_T=1 -DHAVE_UINT=1 -DHAVE_UINT_T=1 -DHAVE_UINT16_T=1
-DHAVE_DIRENT_H=1 -DHAVE_SYS_BYTEORDER_H=1 -DHAVE_MEMORY_H=1 -DHAVE_UNISTD_H=1
-DHAVE_NL_TYPES_H=1 -DHAVE_MALLOC_H=1 -DHAVE_X11_XKBLIB_H=1
-DHAVE_SYS_STATVFS_H=1 -DHAVE_SYS_STATFS_H=1 -DHAVE_LIBM=1 -DHAVE_LIBDL=1
-DHAVE_LIBC=1 -DHAVE_LIBSOCKET=1 -DFUNCPROTO=15 -DHAVE_XSHM=1 -D_REENTRANT=1
-DHAVE_RANDOM=1 -DHAVE_STRERROR=1 -DHAVE_LCHOWN=1 -DHAVE_FCHMOD=1
-DHAVE_SNPRINTF=1 -DHAVE_MEMMOVE=1 -DHAVE_RINT=1 -DHAVE_STAT64=1
-DHAVE_LSTAT64=1 -DHAVE_FLOCKFILE=1 -DHAVE_LOCALTIME_R=1 -DHAVE_STRTOK_R=1
-DHAVE_LANGINFO_CODESET=1 -DVA_COPY=va_copy -DHAVE_VA_COPY=1
-DHAVE_I18N_LC_MESSAGES=1 -DMOZ_DEFAULT_TOOLKIT=\"gtk\" -DMOZ_WIDGET_GTK=1
-DMOZ_ENABLE_XREMOTE=1 -DMOZ_X11=1 -DMOZ_BUILD_APP=suite
-DMOZ_DISTRIBUTION_ID=\"org.mozilla\" -DMOZ_ENABLE_COREXFONTS=1
-DMOZ_EXTRA_X11CONVERTERS=1 -DOJI=1 -DIBMBIDI=1 -DMOZ_VIEW_SOURCE=1
-DACCESSIBILITY=1 -DMOZ_XPINSTALL=1 -DMOZ_JSLOADER=1 -DMOZ_XTF=1
-DHAVE_GSSAPI_GSSAPI_H=1 -DHAVE_GSS_C_NT_HOSTBASED_SERVICE=1 -DMOZ_MATHML=1
-DMOZ_SVG=1 -DMOZ_SVG_RENDERER_LIBART=1 -DMOZ_LOGGING=1
-DMOZ_USER_DIR=\".mozilla\" -DHAVE_ALLOCA_H=1 -DHAVE_ALLOCA=1 -DMOZ_XUL=1
-DMOZ_PROFILESHARING=1 -DMOZ_PROFILELOCKING=1 -DSUNCTL=1
-DMOZ_DLL_SUFFIX=\".so\" -DXP_UNIX=1 -DUNIX_ASYNC_DNS=1 -DJS_THREADSAFE=1
-DNS_PRINT_PREVIEW=1 -DNS_PRINTING=1 -DMOZILLA_LOCALE_VERSION=\"1.8b\"
-DMOZILLA_REGION_VERSION=\"1.8b\" -DMOZILLA_SKIN_VERSION=\"1.5\" 
-D_MOZILLA_CONFIG_H_ -DMOZILLA_CLIENT nsMessenger.cpp
"nsMessenger.cpp", line 2178: Error: Cannot use const char* to initialize char*.
"nsMessenger.cpp", line 2370: Warning (Anachronism): Formal argument 4 of type
extern "C" int(*)(const void*,const void*,void*) in call to NS_QuickSort(void*,
unsigned, unsigned, extern "C" int(*)(const void*,const void*,void*), void*) is
being passed int(*)(const void*,const void*,void*).
1 Error(s) and 1 Warning(s) detected.
make[6]: *** [nsMessenger.o] Error 1
make[6]: Leaving directory
`/usr/local/mozilla/production/sources/mozilla/mailnews/base/src'
make[5]: *** [libs] Error 2
make[5]: Leaving directory
`/usr/local/mozilla/production/sources/mozilla/mailnews/base'
make[4]: *** [libs] Error 2
make[4]: Leaving directory `/usr/local/mozilla/production/sources/mozilla/mailnews'
make[3]: *** [libs] Error 2
make[3]: Leaving directory `/usr/local/mozilla/production/sources/mozilla'
make[2]: *** [all] Error 2
make[2]: Leaving directory `/usr/local/mozilla/production/sources/mozilla'
make[1]: *** [built] Error 2
make[1]: Leaving directory `/usr/local/mozilla/code/mozilla'


The line 2178 is :
char * partId = strstr(aAttachmentUrl, partIdPrefix);

Indeed in C++ strstr return a const char* :
const char *strstr(const char *s1, const char *s2);
And a char* in C :
char *strstr(const char *s1, const char *s2);

For information :
Compilation of the last nightly build on SunOS 5.8 Generic_108528-24 sun4u sparc
SUNW,Ultra-5_10
With :  
Sun WorkShop 6 update 2 C 5.3 Patch
Sun WorkShop 6 update 2 C++ 5.3 Patch

Reproducible: Always

Steps to Reproduce:
1.compile it
2.
3.
Actual Results:  
build fails

Expected Results:  
build

Comment 1

[s.despret]

Sorry on the cvs Log I can see that the 1.309 version correct this bug.
I try this immediatly.
I close the bug.