282242 - In <pref-mailnewsOverlay.js>, "redeclaration of var mailnewsEnableNews"

Status: RESOLVED DUPLICATE of bug 102152

(MailNews Core :: Simple MAPI, defect)

Description

[timeless]

Warning: redeclaration of var mailnewsEnableNews
Source File: chrome://messenger-mapi/content/pref-mailnewsOverlay.js
Line: 54, Column: 12
Source Code:
        var mailnewsEnableNews = document.getElementById("mailnewsEnableNews");

Comment 1

[Frank Wein [:mcsmurf]]

Attachment: Patch

Comment 2

[[e-mail]]

Comment on attachment 174306 [details] [diff] [review]
Patch

> function mailnewsOverlayStartup() {
>+    var mailnewsEnableNews = document.getElementById("mailnewsEnableNews");
>+
>     mailnewsOverlayInit();
>     if (!("mapiPref" in parent)) {
>         parent.mapiPref = new Object;
>         parent.mapiPref.isDefaultMailClient = 
>                document.getElementById("mailnewsEnableMapi").checked;
Note that if you also moved the mailnewsEnableMapi declaration to the start of
the function you could then use it here too.

Comment 3

[[e-mail]]

I read my bugmail in the wrong order, bug 102152 shows how it should be done.

Comment 4

[Serge Gautherie (:sgautherie)]

I suggest to resolve this bug as a duplicate of bug 102152 !!?

Comment 5

[Frank Wein [:mcsmurf]]

Hey, why are you setting a Target Milestone :)? If you want to, resolve this bug
as a dupe, but then get sr for your patch and get it checked in.

Comment 6

[Serge Gautherie (:sgautherie)]

The patch is more advanced in bug 102152,
even though it should have been posted here, had I found this bug before.

*** This bug has been marked as a duplicate of 102152 ***

Comment 7

[Serge Gautherie (:sgautherie)]

Comment on attachment 174306 [details] [diff] [review]
Patch

Obsoleting: this patch never got checked in.
(See bug 102152)