282250 - Add negotiateauth support

Status: RESOLVED FIXED

(Camino Graveyard :: General, enhancement, P2)

Description

[ptejad]

User-Agent:       Mozilla/5.0 (Macintosh; U; PPC Mac OS X Mach-O; en-US; rv:1.8b) Gecko/20050119 Camino/0.8+
Build Identifier: Mozilla/5.0 (Macintosh; U; PPC Mac OS X Mach-O; en-US; rv:1.8b) Gecko/20050119 Camino/0.8+

this is similar to https://bugzilla.mozilla.org/show_bug.cgi?id=237572

I have verified that adding the
mozilla/extensions/negotiateauth/libnegotiateauth.dylib file to the project in
the components folder enables spnego authentication for Camino.

You will also want to add a "ac_add_options --enable-extensions=negotiateauth"
and "ac_add_options --enable-crypto" lines to your mozconfig so that it gets built

Reproducible: Always

Comment 1

[Mike Pinkerton (not reading bugmail)]

how large is the optimized dylib? how many people would actually have need for this?

Comment 2

[ptejad]

the file is 68k.  It would be necessary for anyone in an Active Directory domain
using SPNEGO authentication on their websites.

Comment 3

[Jasper]

Seems like a valid request like many others we have, part fo unconfirmed cleanup.

Comment 4

[Mark Mentovai]

Note: since bug 280792, negotiateauth is now called auth on the trunk.

Comment 5

[Samuel Sidler (old account; do not CC)]

Mark, is this just a build-config change?

Mike, 68k seems worth it to me for adding in [negotiate]auth support.

Comment 6

[allan marcus]

Was this ever resolved? Can these libs be included in the build?

Comment 7

[Mike Pinkerton (not reading bugmail)]

*shrug* i don't think anyone else has ever asked for it. i guess if firefox ships with it, we should too. do they for sure?

Comment 8

[allan marcus]

yep, FF does ship with it.

Comment 9

[Smokey Ardisson (offline for a while; not following bugs - do not email)]

I'm looking into this.  While I've added dylibs to our build before, they've been things I'm familiar with and could test myself, so please bear with me ;)  (Also, the branch is a little bit of a rat's nest.)

Comment 10

[allan marcus]

I'd be happy to test and to get some others at at Los Alamos NA Lab to test too. Just let me know when it's ready and if there are specific tests you would like done.

Comment 11

[Smokey Ardisson (offline for a while; not following bugs - do not email)]

I've uploaded a test build that I think has this working.  It's PPC-only, and the trunk rather than branch since the trunk build stuff seemed more straightforward: http://www.ardisson.org/smokey/moz/CaminoTrunk-20070201-auth.dmg

Allan, [e-mail], can you guys take this build for a quick spin and see if it actually works with the auth systems at your labs?  (Note the trunk code is heavily under development right now, so there may be issues with page rendering, etc.; just test the auth stuff ;) )

If all seems well, I'll proceed with the branch work and then get the patches reviewed, and hopefully we'll have this in for 1.1/1.1b1.

Comment 12

[Smokey Ardisson (offline for a while; not following bugs - do not email)]

Attachment: trunk patch v1

This is the patch that I used to make the build in the previous comment.

The configure.in change is untested (I built my tree with --enable-negotiateauth instead, but since we'll burn hereafter, it's not an optional .mozconfig flag but something that should go in configure.in)

Comment 13

[allan marcus]

woowoo! Kerberos auth stuff seems to work fine with the version you built. I look forward to seeing it in main.

-Allan

Comment 15

[Smokey Ardisson (offline for a while; not following bugs - do not email)]

Here's a branch build, same deal as the trunk (except it should be stable enough for daily use):

http://www.ardisson.org/smokey/moz/Camino-1.1a2+20070201-auth.dmg

Please let us know if this works with your auth systems, and if so, I'll get the patches reviewed.

Comment 16

[Smokey Ardisson (offline for a while; not following bugs - do not email)]

Attachment: Branch patch v1

Here's the patch for the 1.8 branch, used for the build above.  Once again, the configure.in change isn't tested (I built with --enable-extensions=all,our,default,extensions,auth in my .mozconfig instead).

Comment 17

[allan marcus]

I'm downloading now and will start to use as a my primary browser after download. Thanks for the incredibly fast response. 

Comment 18

[allan marcus]

I've been using it for a few days and it seems to work. Slow to launch, but that's probably because it's a PPC application (hopefully we'll see a universal version soon :-).  

Comment 19

[Smokey Ardisson (offline for a while; not following bugs - do not email)]

Comment on attachment 253789 [details] [diff] [review]
Branch patch v1

Allan, thanks for the testing!

We'll try to get this in for 1.1b1 (fingers crossed, as we'll have to negotiate with Core on configure.in change).

Comment 20

[Mark Mentovai]

Comment on attachment 253692 [details] [diff] [review]
trunk patch v1

Thanks for remembering nsStaticComponents.cpp!

Comment 21

[Smokey Ardisson (offline for a while; not following bugs - do not email)]

Comment on attachment 253789 [details] [diff] [review]
Branch patch v1

Requesting branch approval for the configure.in portion of this patch (which is a change to the Camino-only section).

Comment 22

[Jay Patel [:jay]]

Comment on attachment 253789 [details] [diff] [review]
Branch patch v1

Approved for 1.8 branch, a=jay for drivers.

Comment 23

[froodian (Ian Leue)]

Checked in on trunk and MOZILLA_1_8_BRANCH.

Comment 24

[Smokey Ardisson (offline for a while; not following bugs - do not email)]

Allan, you can grab an official nightly beginning Tuesday morning and get your authentication with Universal goodness: http://www.caminobrowser.org/download/releases/nightly/

Comment 25

[Samuel Sidler (old account; do not CC)]

Moving fixed "1.2" bugs to 1.1 where they were really fixed. Filter on CaminoFixed1.1 for bugmail purposes.