282267 - product name is checked twice in enter_bug.cgi

Status: RESOLVED FIXED

(Bugzilla :: Creating/Changing Bugs, defect)

Description

[Frédéric Buclin]

if(!CanEnterProduct($product))
{
    ThrowUserError("entry_access_denied", { product => $product});         
}

GetVersionTable();

if (lsearch(\@::enterable_products, $product) == -1) {
    ThrowUserError("invalid_product_name", { product => $product});
}


CanEnterProduct() checks that the product exists and that the user is allowed to
enter bugs in this product. If not, an error message is displayed in a way such
that the user cannot distinguish between an invalid product name and a product
which requires privs, for confidential reasons. Then, the second check is useless.

Comment 1

[Frédéric Buclin]

Attachment: patch, v1

Comment 2

[Max Kanat-Alexander]

Doesn't that just mean that the invalid_ check should be moved *above* the other
check, so that we get a sensible message if we have an invalid product?

Comment 3

[Max Kanat-Alexander]

Comment on attachment 174330 [details] [diff] [review]
patch, v1

r=mkanat on inspection and discussion with LpSolit in IRC.

Comment 4

[Shane H. W. Travis]

Checking in enter_bug.cgi;
/cvsroot/mozilla/webtools/bugzilla/enter_bug.cgi,v  <--  enter_bug.cgi
new revision: 1.104; previous revision: 1.103
done