282289 - FormatDouble called too many times from BugMail.pm

Status: RESOLVED WONTFIX

(Bugzilla :: Email Notifications, defect)

Description

[Max Kanat-Alexander]

I profiled process_bug with enableSendMail turned off, and with a bug with 1000
CCs. Here are the top few results:

%Time    Sec.     #calls   sec/call  F  name
13.73    6.5004    13958   0.000466     Bugzilla::BugMail::FormatDouble
11.01    5.2153      997   0.005231     Bugzilla::BugMail::NewProcessOnePerson
 9.35    4.4290     5107   0.000867     DBI::st::execute

Note that we spend an lot of time in FormatDouble, because we call it 14 times
for EACH user.

Really, we could just do all of the FormatDouble calls outside of
NewProcessOnePerson, in ProcessOneBug, instead.

Comment 1

[Max Kanat-Alexander]

Honestly, I think fixing this would add to code complexity more than it would actually help anything. Also, I think we mostly use wrap_hard instead of format calls, so this probably doesn't even matter. And this is a CPU issue--it's pretty easy to get faster CPUs or throw more webheads at Bugzilla, nowadays.