Closed
Bug 282296
Opened 20 years ago
Closed 20 years ago
[FIX]nsWindowWatcher::FindItemWithName() broken
Categories
(Core :: DOM: Navigation, defect, P1)
Core
DOM: Navigation
Tracking
()
RESOLVED
FIXED
mozilla1.8beta2
People
(Reporter: jst, Assigned: bzbarsky)
Details
Attachments
(1 file)
|
12.64 KB,
patch
|
danm.moz
:
review+
jst
:
superreview+
|
Details | Diff | Splinter Review |
According to your bug 103638 comment 58, nsWindowWatcher::FindItemWithName() is, and has been broken wrt how it uses the docshell API FindItemWithName().
|
Assignee | |
Comment 1•20 years ago
|
||
So specifically, as currently written nsWindowWatcher::GetWindowByName will never return a window for things like "_self", say. Is that the desired behavior? Or should those just return the first window the windowwatcher tries?
|
|
Assignee | |
Comment 2•20 years ago
|
||
This patch just makes us do the same thing in nsWindowWatcher::FindItemWithName as we do in nsDocShellTreeOwner::FindItemWithNameAcrossWindows (and in fact, implements the latter in terms of the former). The rest of what the patch does should be either pretty clear or commented in the patch... I tested the testcases in bug 279495 and bug 278916 in TestGTKEmbed with this patch, and they look good.
Attachment #176060 -
Flags: superreview?(jst)
Attachment #176060 -
Flags: review?(danm.moz)
|
|
Assignee | |
Updated•20 years ago
|
Priority: -- → P1
Summary: nsWindowWatcher::FindItemWithName() broken → [FIX]nsWindowWatcher::FindItemWithName() broken
Target Milestone: --- → mozilla1.8beta2
|
Reporter | |
Comment 3•20 years ago
|
||
Comment on attachment 176060 [details] [diff] [review] Proposed patch sr=jst
Attachment #176060 -
Flags: superreview?(jst) → superreview+
Attachment #176060 -
Flags: review?(danm.moz) → review+
|
|
Assignee | |
Comment 4•20 years ago
|
||
Fixed.
Status: NEW → RESOLVED
Closed: 20 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•