282339 - JS Tests for toLocaleString should be removed or changed to pass

Status: VERIFIED FIXED

(Core :: JavaScript Engine, defect)

Description

[Frank Wein [:mcsmurf]]

The test found under
http://lxr.mozilla.org/mozilla/source/js/tests/ecma_3/Date/15.9.5.5.js and the
test under
http://lxr.mozilla.org/mozilla/source/js/tests/ecma_3/Date/15.9.5.6.js use
Date.parse in combination with parse toLocaleDate(String). This is not expected
to work per Bug 282115 so either
1) these tests should be removed or
2) these tests should be changed, so they pass.

Comment 1

[Phil Schwartau]

The tests have value for English locales. Shouldn't they be retained
to at least allow us to test that English locales are working properly?

Testers in non-English locales could simply add the tests to their
"skip lists" when running the test driver.

(See http://lxr.mozilla.org/mozilla/source/js/tests/README-jsDriver.html)

Comment 2

[Frank Wein [:mcsmurf]]

Attachment: Add some comment

Comment 3

[Phil Schwartau]

Comment on attachment 175445 [details] [diff] [review]
Add some comment

r=pschwartau

Great idea to add these!

Comment 4

[Christian :Biesinger (don't email me, ping me on IRC)]

Checking in js/tests/ecma_3/Date/15.9.5.5.js;
/cvsroot/mozilla/js/tests/ecma_3/Date/15.9.5.5.js,v  <--  15.9.5.5.js
new revision: 1.3; previous revision: 1.2
done
Checking in js/tests/ecma_3/Date/15.9.5.6.js;
/cvsroot/mozilla/js/tests/ecma_3/Date/15.9.5.6.js,v  <--  15.9.5.6.js
new revision: 1.3; previous revision: 1.2
done

Comment 5

[Bob Clary [:bc] (inactive)]

verified fixed except for the known crash on windows 1.9 ecma_3/Date/15.9.5.[56].js