282351 - Dispatch load event after instance data loading

Status: RESOLVED FIXED

(Core Graveyard :: XForms, defect)

Description

[Olli Pettay [:smaug][[e-mail]] (holiday -> Aug30)]

Comment 1

[Olli Pettay [:smaug][[e-mail]] (holiday -> Aug30)]

Attachment: v1

This puts instance data loading to the load group of the main document.

Comment 2

[Olli Pettay [:smaug][[e-mail]] (holiday -> Aug30)]

Attachment: v.1.0.1

Removed few extra lines.

Comment 3

[Darin Fisher]

don't you have to throw some exception if LoadExternalInstance fails?

Comment 4

[Olli Pettay [:smaug][[e-mail]] (holiday -> Aug30)]

(In reply to comment #3)
> don't you have to throw some exception if LoadExternalInstance fails?

model->InstanceLoadFinished(PR_FALSE);

Comment 5

[Darin Fisher]

btw, the patch looks good overall.. i was just concerned about error handling.

Comment 6

[Olli Pettay [:smaug][[e-mail]] (holiday -> Aug30)]

Attachment: v.1.0.2

Still minor tweak.

Comment 7

[aaronr]

nit: might want to comment nsXFormsInstanceElement::LoadExternalInstance to say
why you are using the load group approach (i.e. what problem you are trying to
solve).  Otherwise looks ok to me.

Comment 8

[Allan Beaufour]

Comment on attachment 174406 [details] [diff] [review]
v.1.0.2

I agree with Aaron, you should put the rationale somewhere in a comment. But
except for that it looks, and works, as it should as far as I can see.

Comment 9

[Olli Pettay [:smaug][[e-mail]] (holiday -> Aug30)]

Attachment: v.1.0.2 + a comment

Comment 10

[Allan Beaufour]

Checked in.