282380 - Enter doesn't copy proxy settings to FTP/SSL/Gopher

Status: RESOLVED FIXED

(SeaMonkey :: Preferences, defect)

Description

[Frank Wein [:mcsmurf]]

To reproduce:
1. Open Preferences, Advanced->Proxies
2. Select Manual proxy configuration
3. Enter something for the proxy server field (or change the ports field)
4. Confirm changes by pressing Enter.
5. Open prefs again, click on Advanced to observe that proxy settings have not
been copied.

If you click OK, the settings are copied.

Comment 1

[Frank Wein [:mcsmurf]]

Stefan: Do you want to fix this bug when you have time :)? You created this new
proxy dialog, that's why i'm asking you.

Comment 2

[Stefan Borggraefe]

Attachment: Patch

Ok, the problem here is that the change event is only processed when the prefs
are already saved. The function FixProxyURL() suffers from the same problem.

This patch introduces the possibility to register functions to be called just
before the prefs are saved.

I also fixed the emacs mode-line in nsPrefWindow.js, because the specified mode
created tabs, and added a correct mode-line to the other touched file (I
actually use emacs ;-) ).

Comment 3

[[e-mail]]

I wonder if it would be possible to get the Enter ke to fire onchange first?

Comment 4

[Stefan Borggraefe]

(In reply to comment #3)
> I wonder if it would be possible to get the Enter ke to fire onchange first?

I don't know how/where I could change the order of the fired events. If this is
the right way to fix this bug, someone else has to take it.

Comment 5

[[e-mail]]

My patch to bug 225563 fixes this, but unfortunately I need to update it :-/

Comment 6

[Stefan Borggraefe]

Comment on attachment 174633 [details] [diff] [review]
Patch

Great news! Thanks Neil. :-)

Comment 7

[[e-mail]]

I'm claiming this was fixed by the checkin to bug 225563.