282384 - Templatize the 'select classification' bit of editproducts

Status: RESOLVED FIXED

(Bugzilla :: Administration, task)

Description

[GavinS]

Comment 1

[GavinS]

Attachment: templatize the 'select classification' bit of editproducts v1

Note that this patch includes the editproducts footer template already reviewed
as part of bug 282384. It is needed to test this patch. I'll update this patch
or the other one as necessary to remove that bit, depending on which patch gets
checked in first...

Comment 2

[GavinS]

Attachment: templatize the 'select classification' bit of editproducts v2

Updates after the other editproducts templates have been checked in. Also,
added an 'add product' link to the table

Comment 3

[Frédéric Buclin]

Comment on attachment 174626 [details] [diff] [review]
templatize the 'select classification' bit of editproducts v2

Looks good; works well. r=LpSolit

If a classification has a name such as :o' then I cannot add products, or more
precisely this new product is not displayed when coming back to this page.
Looking at my DB, it appears that this product has classification_id=0 !! But
this problem also appears without this patch so this is really a different bug.
Could you please open a bug for that (if confirmed) and eventually assigned it
to me? My DB is now corrupted. :(

Comment 4

[GavinS]

Attachment: templatize the 'select classification' bit of editproducts v3

Just un-bitrotting, ready for check-in, but should probably get another r+
anyway

Comment 5

[Frédéric Buclin]

Comment on attachment 177655 [details] [diff] [review]
templatize the 'select classification' bit of editproducts v3

>+                  $dbh->sql_group_by('classifications.id',
>+                                     'classifications.name,
>+                                      classifications.description') . "

I first thought there were missing quotes around the second and the third
items, but looking at sql_group_by(), I realized this was correct... Feel
better now. :)

r=LpSolit

Comment 6

[Frédéric Buclin]

Checking in editproducts.cgi;
/cvsroot/mozilla/webtools/bugzilla/editproducts.cgi,v  <--  editproducts.cgi
new revision: 1.76; previous revision: 1.75
done
Checking in template/en/default/admin/products/footer.html.tmpl;
/cvsroot/mozilla/webtools/bugzilla/template/en/default/admin/products/footer.html.tmpl,v
 <--  footer.html.tmpl
new revision: 1.2; previous revision: 1.1
done
RCS file:
/cvsroot/mozilla/webtools/bugzilla/template/en/default/admin/products/list-classifications.html.tmpl,v
done
Checking in template/en/default/admin/products/list-classifications.html.tmpl;
/cvsroot/mozilla/webtools/bugzilla/template/en/default/admin/products/list-classifications.html.tmpl,v
 <--  list-classifications.html.tmpl
initial revision: 1.1
done