282429 - Re-design Message Status Bars (junk bar & remote content bar) to be more flexible

Status: RESOLVED FIXED

(Thunderbird :: General, defect)

Description

[Scott MacGregor]

Before I add a 3rd message status bar (one for phishing e-mails), I want to
re-organize the existing two message status bars into a design that makes it
easier to add new ones.

Comment 1

[Scott MacGregor]

Attachment: the fix

1) Use a deck to stack the msg status bars instead of maintainig separate boxes
for each message. Changing the status message is now as easy as just changing
the selectedIndex on the deck.

2) Add a small class object for managing the status bar with methods for
setting the junk bar, setting the remote content bar and clearing the msg
status bar. 

3) Make the junkbar style match the remote content bar style (i.e. lose the
blue gradient on the backgroun). Consolidate some CSS for all our msg status
bars to use the same style rules.

This patch should make adding another status bar for e-mail scams much easier.

Comment 2

[David :Bienvenu]

Comment on attachment 174448 [details] [diff] [review]
the fix

+    var hasRemoteContent = false;
+    if (aMsgHdr && aMsgHdr.getUint32Property("remoteContentPolicy") ==
kBlockRemoteContent)
+      hasRemoteContent = true;

can be var hasRemoteContent = (aMsgHdr && aMsgHdr.getUint32Property...

in fact, you don't even need a separate var for hasRemoteContent but that would
sacrifice a little readability :-)

Comment 3

[Markus Faßbender]

Isn't it better for the user, when these message status bars have another color.
Maybe yellow, like the pop-up-blocker-bar in Firefox ?

So the user will better notice that status bar.

Comment 4

[Scott MacGregor]

ummm they are yellow like the firefox status bar now...

Comment 5

[Markus Faßbender]

Sorry, I only saw the screenshot in the forum 
http://forums.mozillazine.org/viewtopic.php?t=220681&sid=cc9bdbad6aad537fbdbca9bb0cb21f21
and there the status bar wasn't yellow :-(