282438 - Improperly nested menupopupend events breaks screen reader support

Status: RESOLVED FIXED

(Core :: Disability Access APIs, defect)

Description

[Aaron Leventhal]

When autocomplete widgets open we are firing menupopupstart but no menupopupend.
This causes the screen reader to think it is still in a menu when it isn't,
completely breaking accessibility from that point on.

This is a regression caused by the fix for bug 281568

Comment 1

[Aaron Leventhal]

Attachment: Fire DOMMenuInactive for destroyed popupsetframes

Comment 2

[Aaron Leventhal]

Attachment: Fire in ActivatePopup()

Comment 3

[[e-mail]]

Comment on attachment 174481 [details] [diff] [review]
Fire in ActivatePopup()

This looks right apart from a space before the ? and a missing declaration of
mIsOpen.

Could you file a bug on passing mIsOpen to SyncViewWithFrame to avoid having to
use the menutobedisplayed attribute?

Comment 4

[Aaron Leventhal]

Attachment: Fix whitespace, add forgotton nsPopupSetFrame.h with mIsOpen declaration

Comment 5

[Aaron Leventhal]

Comment on attachment 174491 [details] [diff] [review]
Fix whitespace, add forgotton nsPopupSetFrame.h with mIsOpen declaration

Needed for tight testing cycle with screen reader developer and testers.

Comment 6

[Mike Kaply [:mkaply]]

Comment on attachment 174491 [details] [diff] [review]
Fix whitespace, add forgotton nsPopupSetFrame.h with mIsOpen declaration

a=mkaply.

Comment 7

[Mike Kaply [:mkaply]]

Comment on attachment 174491 [details] [diff] [review]
Fix whitespace, add forgotton nsPopupSetFrame.h with mIsOpen declaration

too late

Comment 8

[Aaron Leventhal]

/cvsroot/mozilla/layout/xul/base/src/nsBoxFrame.cpp,v  <--  nsBoxFrame.cpp
new revision: 1.268; previous revision: 1.267
done
Checking in layout/xul/base/src/nsBoxFrame.h;
/cvsroot/mozilla/layout/xul/base/src/nsBoxFrame.h,v  <--  nsBoxFrame.h
new revision: 1.92; previous revision: 1.91
done
Checking in layout/xul/base/src/nsPopupSetFrame.h;
/cvsroot/mozilla/layout/xul/base/src/nsPopupSetFrame.h,v  <--  nsPopupSetFrame.h
new revision: 1.42; previous revision: 1.41
done
Checking in layout/xul/base/src/nsPopupSetFrame.cpp;
/cvsroot/mozilla/layout/xul/base/src/nsPopupSetFrame.cpp,v  <--  nsPopupSetFrame.cpp
new revision: 1.120; previous revision: 1.119
done

Comment 9

[Firefox Bug Husbandry Bot]

https://bugzilla.mozilla.org/show_bug.cgi?id=1527381