Closed Bug 282486 Opened 20 years ago Closed 20 years ago

dead connections not removed from connection cache

Categories

(MailNews Core :: Networking: IMAP, defect)

Product:
MailNews Core
Component:
Networking: IMAP
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

(Not tracked)

Status:
RESOLVED FIXED

People

(Reporter: Bienvenu, Assigned: Bienvenu)

Details

Attachments

(1 file)

proposed fix
2.08 KB, patch
mscott
: superreview+
sspitzer
: approval1.8b+
Details | Diff | Splinter Review 
As part of reworking the shutting down of connections to avoid a thread-safety
assertion, I broke the removing of connections from the imap server connection
cache, which means you can eventually run out of connections. Thx to Seth for
his help figuring this out.

The fix is to move the code that removes a connection from the connection cache
to CloseStreams, before we clear out m_server...
Attached patch proposed fix — — Splinter Review 
I also added a log statement that should help diagnose problems like this in
the future.
Attachment #174507 - Flags: superreview?(mscott)
Attachment #174507 - Flags: approval1.8b?
this needs to block 1.8b...I'm surprised no one has reported this.
Flags: blocking1.8b?
Attachment #174507 - Flags: superreview?(mscott) → superreview+
Attachment #174507 - Flags: approval1.8b? → approval1.8b+
Status: NEW → RESOLVED
Closed: 20 years ago
Resolution: --- → FIXED
Flags: blocking1.8b? → blocking1.8b+
Product: Core → MailNews Core
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: