282493 - New runtests script for non-db-compatible code

Status: NEW

(Bugzilla :: Testing Suite, enhancement)

Description

[Max Kanat-Alexander]

An excellent email from Joel:

   You should add a runtests.pl test that helps find any new cases of 
non-cross-db code.  It would probably require a long list of exceptions 
initially, but the list should monotonically shrink.
----------

  So what I think we'll do is we'll just check this in after bug 280493, and
then the only exceptions will be files in the Bugzilla/DB/ directory.

  Here's the SQL we need to look for and tell people to replace with
Bugzilla::DB functions:

  LOCK TABLES / UNLOCK TABLES
  REGEXP / NOT REGEXP
  LIMIT
  TO_DAYS
  DATE_FORMAT
  INTERVAL
  CONCAT

  This SQL is just not compatible, and needs to be turned into something
ANSI-standard or something else:

  IFNULL
  enum-type fields
  timestamp-type fields
  (column IS NOT NULL) in the SELECT
  REPLACE INTO
  All statements in a WHERE clause must have an =
  IF(
  INSERT with multiple VALUES paren-groups

  I'm not sure that we can test for all of those, but all of them that can be
tested for should be.

Comment 1

[Max Kanat-Alexander]

INSTR should also not be used. We have a sql_position function for it, now.

Comment 2

[Frédéric Buclin]

Only security and dataloss fixes will be accepted on the 2.20 branch.

Comment 3

[Frédéric Buclin]

Bugzilla 3.2 and 3.4 are closed for enhancement requests.