282510 - error when modifying group

Status: RESOLVED FIXED

(Bugzilla :: Administration, task)

Description

[Cédric Caron]

When modify a group I receive the folowing essor

[Wed Feb 16 23:49:09 2005] editgroups.cgi: Argument "" isn't numeric in 
numeric ne (!=) at C:\Inetpub\Orchid\Bugs\editgroups.cgi line 605. [Wed Feb 16 
23:49:09 2005] editgroups.cgi: Use of uninitialized value in numeric ne (!=) 
at C:\Inetpub\Orchid\Bugs\editgroups.cgi line 619.

Comment 1

[Frédéric Buclin]

where do you see that error? In the apache log file or is it a Bugzilla error
message?

Comment 2

[Frédéric Buclin]

And could you write here which lines it is in editgroups.cgi (605, 619)? A new
version has been uploaded recently (a few hours ago) so I don't know which
version you have.

Comment 3

[Cédric Caron]

The error is displayed at the top of the page in my browser (I am using IIS 
not apache)

line 605: if (($cgi->param("oldgrp-$v") != $grp) && ($v != $gid)) {
line 619: if ($cgi->param("oldbless-$v") != $bless) {

I am using the latest version of the file. I made an update just before 
reporting this bug

Comment 4

[:glob ✱]

confirming and taking

Comment 5

[:glob ✱]

this isn't an iis only issue, the error shows up in apache's error log.

Comment 6

[:glob ✱]

Attachment: simple fix

simple fix, map an empty param to 0

Comment 7

[:glob ✱]

Attachment: v2

updated patch as per bug 277768 comment 19

Comment 8

[Frédéric Buclin]

Attachment: add hidden fields with value '0', v3

Comment 9

[:glob ✱]

Comment on attachment 174545 [details] [diff] [review]
add hidden fields with value '0', v3

r=glob

Comment 10

[Dave Miller [:justdave]]

Comment on attachment 174545 [details] [diff] [review]
add hidden fields with value '0', v3

While I can understand how missing the value in the template would cause this,
shouldn't we be validating the data in the CGI instead of letting it throw an
error if it's missing?

This patch looks good to me, but I don't think it's enough.  We should make the
back end do a polite error or recover gracefully if the data doesn't validate
as well.

BTW, IIS is the reason that anything showing up in the error log is a bug.  IIS
sends stderr to the user's browser instead of logging it (which really confuses
things if it comes before the headers).

Does this bug exist in 2.18?  If so, this is a candidate for backporting.

Comment 11

[:glob ✱]

Attachment: patch cgi and template

merges the cgi and template patches, as per justdave's comments.

this bug isn't present in 2.18

Comment 12

[:glob ✱]

Checking in editgroups.cgi;
/cvsroot/mozilla/webtools/bugzilla/editgroups.cgi,v  <--  editgroups.cgi
new revision: 1.48; previous revision: 1.47
done
Checking in template/en/default/admin/groups/edit.html.tmpl;
/cvsroot/mozilla/webtools/bugzilla/template/en/default/admin/groups/edit.html.tmpl,v
 <--  edit.html.tmpl
new revision: 1.5; previous revision: 1.4
done

my first checking :)