282613 - sidebar doesn't contain important admin edit flags

Status: RESOLVED FIXED

(Bugzilla :: User Interface, defect)

Description

[Jared Warren]

User-Agent:       Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.7.5) Gecko/20041107 Firefox/1.0
Build Identifier: Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.7.5) Gecko/20041107 Firefox/1.0

sidebar.cgi doesn't contain 'edit flags' for users with that permission

Reproducible: Always

Steps to Reproduce:

Comment 1

[Olav Vitters]

Attachment: Patch v1 against Bugzilla HEAD 28 March 2005

I added all the missing pages following the order used by the
useful-links.html.tmpl, these being:
  edit user settings
  edit classifications
  edit flags
  edit field values
  edit whining

Comment 2

[Olav Vitters]

Attachment: Patch v1.1 against Bugzilla HEAD 14 Aug 2005

Patch adds all the missing pages following the order used by the
useful-links.html.tmpl, these being:
  edit user settings
  edit classifications
  edit flags
  edit field values
  edit whining

Difference from v1 is adding the "edit user settings" in the existing
user.groups.tweakparams check.

Previous (some months ago) review request was to jake, but he seems busy.
#mozwebtools suggested kiko.. so kiko, have fun :-) (you should've objected or
ehm.. been around on #mozwebtools ;)

Comment 3

[Vlad Dascalu]

Comment on attachment 192633 [details] [diff] [review]
Patch v1.1 against Bugzilla HEAD 14 Aug 2005

Cool!

I could also do upon checkin:

+      <text class="text-link" onclick="load_relative_url('editproducts.cgi')" value="edit products"/>
       <text class="text-link" onclick="load_relative_url('editcomponents.cgi')" value="edit components"/>

in the suitable branches.

Comment 4

[Vlad Dascalu]

Seems we don't link in general both to editproducts and editcomponents, so I'll check in the patch as it is.

Checking in template/en/default/sidebar.xul.tmpl;
/cvsroot/mozilla/webtools/bugzilla/template/en/default/sidebar.xul.tmpl,v  <--  sidebar.xul.tmpl
new revision: 1.19; previous revision: 1.18
done

Checking in template/en/default/sidebar.xul.tmpl;
/cvsroot/mozilla/webtools/bugzilla/template/en/default/sidebar.xul.tmpl,v  <--  sidebar.xul.tmpl
new revision: 1.18.2.1; previous revision: 1.18
done

Checking in template/en/default/sidebar.xul.tmpl;
/cvsroot/mozilla/webtools/bugzilla/template/en/default/sidebar.xul.tmpl,v  <--  sidebar.xul.tmpl
new revision: 1.17.4.1; previous revision: 1.17
done