282621 - error message in the apache log file when creating a new attachment

Status: RESOLVED FIXED

(Bugzilla :: Attachments & Requests, defect)

Description

[Frédéric Buclin]

When creating a new attachment, the following error message appears in the
apache log file:

attachment.cgi: Argument "" isn't numeric in numeric gt (>) at (eval 27) line 244.

This is because $vars->{'flag_types'}->{'flags'} is undefined (it is only
defined when editing existing attachments) and the following test in
flag/list.html.tmpl generates this error:

[% NEXT UNLESS type.flags.size > 0 && type.is_multiplicable && type.is_active %]

type.flags.size is undefined ("").

Comment 1

[Frédéric Buclin]

Attachment: simple patch, v1

Test first if $vars->{'flag_types'}->{'flags'} exists.

Comment 2

[Myk Melez [:myk] [@mykmelez]]

Comment on attachment 174609 [details] [diff] [review]
simple patch, v1

r=myk

Comment 3

[Shane H. W. Travis]

Checking in template/en/default/flag/list.html.tmpl;
/cvsroot/mozilla/webtools/bugzilla/template/en/default/flag/list.html.tmpl,v  <-
-  list.html.tmpl
new revision: 1.17; previous revision: 1.16
done