282624 - toolkit/help depends on either extension/help or browser

Status: RESOLVED FIXED

(SeaMonkey :: Help Viewer, defect)

Description

[Michiel van Leeuwen (email: mvl+moz@)]

http://lxr.mozilla.org/seamonkey/source/toolkit/components/help/content/help.xul#125
uses findAgainCmd.commandkey2 which is defined in two places, both not in toolkit.
http://lxr.mozilla.org/seamonkey/source/extensions/help/resources/locale/en-US/help.dtd#25
and
http://lxr.mozilla.org/seamonkey/source/browser/locales/en-US/chrome/browser/browser.dtd#386

So help doesn't work in sunbird.

(i wanted to file this bug in the tookit product, but there's no help component
there)

Comment 1

[Jeff Walden (gone starting June 8)]

There's a patch in bug 279227 (attachment 172512 [details] [diff] [review]) that fixes this issue (and,
incidentally, fixes the issue for View Source as well).

Comment 2

[Jeff Walden (gone starting June 8)]

Bug 295817 should clear the way for elimination of the app-specific problems,
and I intend to do this for 1.1/1.8.  Expect to see app-independent code by then.

Comment 3

[Jeff Walden (gone starting June 8)]

App-specific theming has been removed in bug 268776, and the entity issue was
resolved a while back in bug 279227.  Apps which ship a proper version of
toolkit (as I hope and assume Sunbird does) should be able to use the help
viewer without hacks.  If you find any issues when Sunbird starts to use the
help viewer, file bugs and assign them to me.