282631 - editor allows insertion of invalid urls for links

Status: UNCONFIRMED

(MailNews Core :: Composition, defect, P5)

Description

[David :Bienvenu]

The editor allows you to enter a url for a link like www.mozilla.org - it used
to be that clicking on a link like that would assume it was an http url, but now
it doesn't. So I'm proposing inserting http:// at link creation time if no
protocol is specified.

Comment 1

[David :Bienvenu]

Attachment: proposed fix

Scott, who should I get r/moa= from in editor land?

Comment 2

[Scott MacGregor]

Comment on attachment 174611 [details] [diff] [review]
proposed fix

Daniel...he's on vacation right now though.

Comment 3

[Daniel Glazman (:glazou) (not active in Mozilla any more)]

Comment on attachment 174611 [details] [diff] [review]
proposed fix

WOW....
What about mailto:[e-mail] URL ??? It has no double-slash...
What about relative URLs ???

Comment 4

[David :Bienvenu]

Boris, I've been meaning to pester you about this for a while. clicking on a
link w/o a protocol stopped working at some point, perhaps because of a security
fix - do you know if it was intentional?

Comment 5

[Boris Zbarsky [:bzbarsky]]

A link without a protocol is just a relative link, and was always treated as
such, as far as I know....

Comment 6

[David :Bienvenu]

in a mail message, it used to be the case that if you got a link like
www.mozilla.org, clicking on it would take you to http://www.mozilla.org - I
just checked with Netscape 7.1 - I believe that Moz 1.7 builds worked the same
way. Now, that may be evil/wrong, but it used to work, and there are
unfortunately users out there who are surprised that it stopped working.

Comment 7

[Boris Zbarsky [:bzbarsky]]

> in a mail message, it used to be the case that if you got a link like
> www.mozilla.org, clicking on it would take you to http://www.mozilla.org

With plaintext or HTML mail?  The plaintext mail from bugzilla for comment 6 of
this bug has "www.mozilla.org" highlighted as a link in mailnews.  When I click
on it, it goes to http://www.mozilla.org.  I'm using SeaMonkey trunk
2005-02-18-05...

Note that in the DOM the link's href is "http://www.mozilla.org" in this case,
as expected -- the http-magic is in the plaintext-to-html converter mailnews
runs on messages.

Comment 8

[Mike Cowperthwaite]

xref bug 166644

Comment 9

[David :Bienvenu]

Attachment: handle anchors and mailto links

I don't know if this will be acceptable to editor, but if we fork this file, I think this patch will help.

Comment 10

[David :Bienvenu]

Comment on attachment 205858 [details] [diff] [review]
handle anchors and mailto links

clearing request to re-request...

Comment 11

[David :Bienvenu]

Comment on attachment 205858 [details] [diff] [review]
handle anchors and mailto links

re-requesting review.

Comment 12

[Daniel Glazman (:glazou) (not active in Mozilla any more)]

Comment on attachment 205858 [details] [diff] [review]
handle anchors and mailto links


> function ValidateData()
> {
>   href = TrimString(gDialog.hrefInput.value);
>   // if no protocol specified, assume http://
>-  if (href.indexOf(":") == -1)
>+  if (href.indexOf(":") == -1 && href[0] != '#')
>     href = "http://" + href;

I don't understand this. If you want to create a link in the
editor to another document like <a href="foo.html">, the
patch above is going to break it and turn it into
<a href="http://foo.html"> ?

Comment 13

[David :Bienvenu]

not working on this - anyone is free to take it.

Comment 14

[Jens Stutte [:jstutte]]

Bulk-downgrade of unassigned, >=5 years untouched DOM/Storage bugs' priority.

If you have reason to believe this is wrong (especially for the severity), please write a comment and ni :jstutte.

Comment 15

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

From point of view of Core, this is not a bug because it shouldn't be done in editor for web-compat of createLink command. It should be done before using the input value to editor. I.e., in the dialog or somewhere.

Moving to Thunderbird because of the reporter.