Hiding last (as in the only) tab causes spewage

RESOLVED FIXED

Status

Other Applications
ChatZilla
--
minor
RESOLVED FIXED
13 years ago
12 years ago

People

(Reporter: Tuukka Tolvanen (sp3000), Assigned: Tuukka Tolvanen (sp3000))

Tracking

Firefox Tracking Flags

(Not tracked)

Details

(Whiteboard: [cz-0.9.68])

Attachments

(1 attachment)

(Assignee)

Description

13 years ago
User-Agent:       Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.8b) Gecko/20050213 Firefox/1.0+
Build Identifier: Chatzilla 0.9.67 [Firefox 1.0+/20050213]

Hiding last tab causes
	[ERROR]	Internal error dispatching command “hide-view”.
	[ERROR]	TypeError: client.viewsArray[i] has no properties @
                <chrome://chatzilla/content/commands.js> 1448

'Hide Tab' is disabled in the context menu when only one tab is open, but
middle-clicking a tab "works".

Reproducible: Always

Steps to Reproduce:
1. Middle click on each chatzilla tab.

Actual Results:  
The hidden view popped back up with an exception.

Expected Results:  
Nothing, perhaps with a message.
(Assignee)

Comment 1

13 years ago
Created attachment 174686 [details] [diff] [review]
patch1

Add check and associared error message against client.viewsArray.length < 2 to
cmdHideView, as in cmdDeleteView.
Assignee: rginda → t.bugz
Status: NEW → ASSIGNED
Attachment #174686 - Flags: review?(silver)

Comment 2

13 years ago
Comment on attachment 174686 [details] [diff] [review]
patch1

r=silver@warwickcompsoc.co.uk
Attachment #174686 - Flags: review?(silver) → review+

Comment 3

13 years ago
Checked in --> FIXED.

In approximately 55 minutes a build with this fix will be available from:
  http://twpol.dyndns.org/mozilla/chatzilla/nightly/
Status: ASSIGNED → RESOLVED
Last Resolved: 13 years ago
Resolution: --- → FIXED

Updated

12 years ago
Whiteboard: [cz-0.9.68]
You need to log in before you can comment on or make changes to this bug.