Closed
Bug 282713
Opened 20 years ago
Closed 20 years ago
Hiding last (as in the only) tab causes spewage
Categories
(Other Applications :: ChatZilla, defect)
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: tuukka.tolvanen, Assigned: tuukka.tolvanen)
Details
(Whiteboard: [cz-0.9.68])
Attachments
(1 file)
|
1.80 KB,
patch
|
bugzilla-mozilla-20000923
:
review+
|
Details | Diff | Splinter Review |
User-Agent: Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.8b) Gecko/20050213 Firefox/1.0+
Build Identifier: Chatzilla 0.9.67 [Firefox 1.0+/20050213]
Hiding last tab causes
[ERROR] Internal error dispatching command “hide-view”.
[ERROR] TypeError: client.viewsArray[i] has no properties @
<chrome://chatzilla/content/commands.js> 1448
'Hide Tab' is disabled in the context menu when only one tab is open, but
middle-clicking a tab "works".
Reproducible: Always
Steps to Reproduce:
1. Middle click on each chatzilla tab.
Actual Results:
The hidden view popped back up with an exception.
Expected Results:
Nothing, perhaps with a message.
|
Assignee | |
Comment 1•20 years ago
|
||
Add check and associared error message against client.viewsArray.length < 2 to cmdHideView, as in cmdDeleteView.
|
||
Comment 2•20 years ago
|
||
Comment on attachment 174686 [details] [diff] [review] patch1 r=silver@warwickcompsoc.co.uk
Attachment #174686 -
Flags: review?(silver) → review+
|
|
||
Comment 3•20 years ago
|
||
Checked in --> FIXED. In approximately 55 minutes a build with this fix will be available from: http://twpol.dyndns.org/mozilla/chatzilla/nightly/
Status: ASSIGNED → RESOLVED
Closed: 20 years ago
Resolution: --- → FIXED
|
|
||
Updated•19 years ago
|
Whiteboard: [cz-0.9.68]
You need to log in
before you can comment on or make changes to this bug.
Description
•