282735 - [FIX]XBL treats <children> tags in all namespaces as <xbl:children>

Status: VERIFIED FIXED

(Core :: XBL, defect, P2)

Description

[Boris Zbarsky [:bzbarsky]]

There's no namespace check; there should be one.

Comment 1

[Boris Zbarsky [:bzbarsky]]

Attachment: XBL for testcase

Comment 2

[Boris Zbarsky [:bzbarsky]]

Attachment: XBL for testcase

Comment 3

[Boris Zbarsky [:bzbarsky]]

Attachment: Testcase

Comment 4

[Boris Zbarsky [:bzbarsky]]

Attachment: Proposed patch

Comment 5

[Boris Zbarsky [:bzbarsky]]

Attachment: Diff -w for ease of review

Comment 6

[Johnny Stenback (:jst)]

Comment on attachment 174709 [details] [diff] [review]
Diff -w for ease of review

+nsXBLPrototypeBinding::GetNestedChildren():
+    if (child->IsContentOfType(nsIContent::eELEMENT) &&
+	 child->GetNodeInfo()->Equals(aTag, aNamespace)) {

You could save yourself a virtual call there if you'd cat the nodeinfo into a
local weak pointer and then null check it before using it, if you'd do that you
wouldn't need to do the IsContentOfType() check.

r+sr=jst

Comment 7

[Boris Zbarsky [:bzbarsky]]

Fixed with that comment.

Comment 8

[Doron Rosenberg (IBM)]

verified.

Comment 9

[Scott MacGregor]

This patch broke the quick search drop down box for Thunderbird's quick search
boxes (visible from the mail 3-pane, the address book and the contacts sidebar
panel).

Please see Bug #284126 for details.