Closed Bug 282742 Opened 20 years ago Closed 11 years ago

Support nsIContent::IsContentOfType(nsIContent::eXTF)

Categories

(Core Graveyard :: XTF, defect)

defect
Not set
normal

Tracking

(Not tracked)

RESOLVED WONTFIX

People

(Reporter: aaronlev, Assigned: alex)

Details

Attachments

(1 file)

nsIContent::IsContentOfType(nsIContent::eXTF) would be useful, rather than
needing to use a QI to see if we're currently on an XTF element.
Attached patch Simple patchSplinter Review
Attachment #174715 - Flags: superreview?(bzbarsky)
Attachment #174715 - Flags: review?(alex)
OS: Windows XP → All
Hardware: PC → All
What does "XTF elements" mean?  It seems rather underdefined...  In particular,
why is this needed for nsXTFVisualWrapper, but not nsXTFElementWrapper?
Good question. I don't know enough about XTF to answer. Maybe we need it on the
other XTF elements, but I'm not sure what each class is used for. When is
nsXTFElementWrapper used?
Comment on attachment 174715 [details] [diff] [review]
Simple patch

Marking sr- pending better documentation of what this constant means, at least.
Attachment #174715 - Flags: superreview?(bzbarsky) → superreview-
Comment on attachment 174715 [details] [diff] [review]
Simple patch

You should either set this for nsXTFElementWrapper (the common baseclass for
all XTF elements: visuals and "display=none"-like elements), or rename it to
something like eXTFVisual - depending on how and where you want to use this
flag.
Attachment #174715 - Flags: review?(alex) → review-
Mass un-assigning bugs assigned to Aaron.
Assignee: aaronleventhal → alex
QA Contact: xtf
XTFVisual is long gone... perhaps under the current code, this could only work for nsXTFElementWrapper.

Is this still wanted?  What clarifications still are needed?
XTF has been removed from the tree.  [xtfisdead] for filtering purposes.
Status: NEW → RESOLVED
Closed: 11 years ago
Resolution: --- → WONTFIX
Product: Core → Core Graveyard
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: