282792 - guarantee existence of the binding manager

Status: RESOLVED FIXED

(Core :: XBL, defect)

Description

[Brian Ryner (not reading)]

We check, very inconsistently, for a null binding manager on documents.  Since
documents create the binding manager up-front, we can just make this part of
Init(), and callers need not check for a null binding manager.  As part of this,
we should rename nsIDocument::GetBindingManager() to BindingManager().

Comment 1

[Brian Ryner (not reading)]

Attachment: patch

Comment 2

[Brian Ryner (not reading)]

Attachment: patch with -w for easier reviewing

Comment 3

[Boris Zbarsky [:bzbarsky]]

Comment on attachment 174753 [details] [diff] [review]
patch with -w for easier reviewing

>Index: extensions/inspector/base/src/inDeepTreeWalker.cpp
>       nsCOMPtr<nsIBindingManager> bindingManager = inLayoutUtils::GetBindingManagerFor(aNode);
>       nsCOMPtr<nsIContent> content = do_QueryInterface(aNode);
>-      if (bindingManager) {

No, this still needs a null-check, I think.  If aNode has a null ownerDocument,
inLayoutUtils::GetBindingManagerFor() will return null....

r+sr=bzbarsky with this change reverted (and the else reinstated).

Comment 4

[Brian Ryner (not reading)]

checked in