282793 - Bugzilla should return 404 for invalid products (e.g. in describecomponents.cgi)

Status: RESOLVED INVALID

(Bugzilla :: Bugzilla-General, defect)

Description

[dolphinling]

If you give an invalid product to bugzilla, e.g. with
http://bugzilla.mozilla.org/describecomponents.cgi?product=blahblahinvalid, it
replies with 

Invalid Product Name
The product name 'blahblahinvalid' is invalid or does not exist.
Please press Back and try again. 

This page should be sent as a 404.

Comment 1

[dolphinling]

On entering a bug with an invalid product,
(https://bugzilla.mozilla.org/enter_bug.cgi?product=blahblahinvalid) it replies
with a permission denied error. 

I can't see any reason for this, it seems like it should also just say invalid
product (if so, someone should file a bug on that), but if there is a reason,
that should be sent as a 403 error rather than a 404. 

Comment 2

[Frédéric Buclin]

I fixed this problem one month ago in bug 153461 where entering an invalid
product now redirect you to a list of available products (limited to the ones
you are allowed to see, of course). This solution is much better than giving a
404 error!

Comment 3

[dolphinling]

It should still give a 404--it's possible to include html in the body of a 404
response. 

(Nice work with that, by the way :-)

Comment 4

[Dave Miller [:justdave]]

The script file itself exists.  It's parameters to it that aren't valid.  That
doesn't qualify for a 404 or 403 error, as that might make a smart useragent
that's paying attention suddenly think the CGI itself doesn't exist or is blocked.

I think the only way this would legitimately work is if we were using PATH_INFO
instead of QUERY_STRING, but we aren't, so we can't.

Comment 5

[Anne (:annevk)]

I disagree. It is just a different page. A stupid UA would thing none of it is
available.