Closed Bug 282816 Opened 20 years ago Closed 20 years ago

Printing. 4 pages print , 2 only have headers and footers [@ nsBlockFrame::SplitPlaceholder]

Categories

(Core :: Layout, defect)

Product:
Core
Component:
Layout
Platform:
x86
All
Type:
defect
Priority:
Not set
Severity:
critical

Tracking

()

Status:
RESOLVED FIXED

People

(Reporter: dragonsclaw, Unassigned)

References

(
URL
)

Details

(Keywords: crash, regression, testcase)

Crash Data

Attachments

(3 files)

Testcase #1 (crash in Print Preview)
1.19 KB, text/html
Details
Crashlog from Camino crash under Mac OS 10.3.8
26.13 KB, text/plain
Details
fix
4.70 KB, patch
Details | Diff | Splinter Review 
User-Agent:       Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.7.5) Gecko/20041107 Firefox/1.0
Build Identifier: Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.7.5) Gecko/20041107 Firefox/1.0

Printing a 4 page web page. the first 2 print fine, the second 2 are missing the
content and only have headers and footers.
Brother MFC8820DN network printer. IE prints all 4 fine.

Reproducible: Always

Steps to Reproduce:
1.View page
2.select print or print preview
3.

Actual Results:  
preview or printed page missing content of last 2 pages.

Expected Results:  
Printed the rest of the content as show in the browser.

Plain Vanilla FireFox. No error messages or hangs. Just does not print all content
Print Preview of URL in Mozilla 2005-02-19-05 trunk Linux leads to a crash:
Talkback: tb3814394x
Assignee: firefox → nobody
Severity: major → critical
Status: UNCONFIRMED → NEW
Component: General → Layout
Ever confirmed: true
Keywords: crash
OS: Windows XP → All
Product: Firefox → Core
QA Contact: general → layout
Version: unspecified → Trunk
I tried the wallpaper in bug 265867 but it did not help...

In a debug build, just reloading the page makes it hang with 100% CPU.

When loading the URL I see these a few times:

###!!! ASSERTION: Abs pos whose parent is not the abs pos containing block?:
'aNewFrame->GetParent() == mAbsoluteItems.containingBlock', file
nsCSSFrameConstructor.cpp, line 1192
###!!! ASSERTION: Scrollframe's frameItems should be exactly the scrolled frame:
'blockItem.childList == scrolledFrame', file nsCSSFrameConstructor.cpp, line 6399
Summary: Printing. 4 pages print , 2 only have headers and footers → Printing. 4 pages print , 2 only have headers and footers [@ nsBlockFrame::SplitPlaceholder]
Looks like it's related to bug 265867 and bug 255748.

Testcase #1 crash also a debug build (not just hang like the URL) and the
wallpaper assertion does trigger and fixes the crash:
###!!! ASSERTION: SplitPlaceholder called with next-in-flow:
'!aPlaceholder.GetNextInFlow()', file nsBlockFrame.cpp, line 4143

I'm guessing the hang prevents us from reaching SplitPlaceholder() - 
there where some infinite loops involved in bug 255748...
Depends on: 255748
Keywords: testcase
*** Bug 282906 has been marked as a duplicate of this bug. ***
FWIW, Camino crashes under this bug when one attempts to print preview:

http://www.apple.com/macmini/

Crashlog above came on Mac OS 10.3.8 while attempting a print preview on the Mac
mini page.
Mats, could you file a separate bug on the asserts in comment 2 (with maybe even
a testcase)?
regressions should block beta
Blocks: 284434
I debugged this a bit and I'll continue tomorrow.

What's happening is that the 'maincontents' div is being broken and the overflow
of the float is being pushed up to the overflow-placeholders list of the <HTML>.
But in ReflowBlockFrame of that <HTML> element, we get to the place where we
detect that we collapsed top borders all the way down hoping there was no
clearance, but there is clearance, so we need to retry. I think we're going to
retry with our overflow-placeholders list still holding that float continuation,
and very bad things are going to happen.
Status: NEW → ASSIGNED
Attached patch fix — — Splinter Review 
A few small things to do here:
-- When we retry reflow to account for unexpected clearance, we must call
UndoSplitPlaceholders to wipe out any frames that were added to our
overflow-placeholders list during the first try.
-- UndoSplitPlaceholders fails to clean up the placeholders in the case when
there were no overflow placeholders already in the list, so fix that.
-- We need to reparent the floats, as well as the placeholders, when we push
them up to an ancestor.

This fixes the crash.
Attachment #176766 - Flags: superreview?(dbaron)
Attachment #176766 - Flags: review?(dbaron)
Comment on attachment 176766 [details] [diff] [review]
fix

This is completely subsumed by my other work on float pagination
Attachment #176766 - Flags: superreview?(dbaron)
Attachment #176766 - Flags: review?(dbaron)
Appears that the fix for bug 263825 fixed this. 

Am not crashing on URL or testcase print preview with Mozilla/5.0 (Windows; U;
Windows NT 5.1; en-US; rv:1.8b2) Gecko/20050328.
yes, that's expected since the fix for this bug was checked in via the fix in
bug 263825.
Status: ASSIGNED → RESOLVED
Closed: 20 years ago
Resolution: --- → FIXED
Crash Signature: [@ nsBlockFrame::SplitPlaceholder]
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: