282858 - Extensions don't work after updating from 2/18 build to 2/19 build

Status: RESOLVED FIXED

(Toolkit :: Add-ons Manager, defect)

Description

[Ryan VanderMeulen [:RyanVM]]

User-Agent:       Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.8b) Gecko/20050219 Firefox/1.0+
Build Identifier: Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.8b) Gecko/20050219 Firefox/1.0+

After updating from a build made yesterday to a build I made today, all my
installed extensions ceased to function.  The icons also switched back from the
extension icons to the generic green puzzle piece icons.

Reproducible: Always

Steps to Reproduce:

Comment 1

[Benjamin Smedberg]

Not sure yet if this is real... I cannot reproduce with existing or new profiles.

Comment 2

[Ryan VanderMeulen [:RyanVM]]

Looks like I'm not the only one seeing it now:
http://forums.mozillazine.org/viewtopic.php?t=221675

Comment 3

[Peter van der Woude [:Peter6]]

->NEW

Comment 4

[Jeremy Priest]

Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.8b2) Gecko/20050219
Firefox/1.0+

I'm using the
[url=http://ftp.mozilla.org/pub/mozilla.org/firefox/nightly/latest-trunk/]current
windows nightly[/url] that is released as an .EXE installer and my extensions
work just fine.

I made a backed up my old profile and erased my previous Firefox and Extensions
folder before installing it but left my plugins alone (which i normally do)

But if you test the
[url=http://ftp.mozilla.org/pub/mozilla.org/firefox/tinderbox-builds/beast-trunk/]hourly
tinderbox build[/url]; currently it disables all extensions.
I guess it could be related to the content.rdf change.

/Ieremiou

Comment 5

[Dan Loomis]

I did not have this problem using the windows .exe intaller from:
http://ftp.mozilla.org/pub/mozilla.org/firefox/nightly/2005-02-19-07-trunk/ 
I currently have adblock, flashblocker, sage, tab browser preferences and
spellbound installed.

Mozilla/5.0 (Windows; U; Windows NT 5.0; en-US; rv:1.8b2) Gecko/20050219
Firefox/1.0+

Comment 6

[Benjamin Smedberg]

Fixed with the second landing, see the link at bug 278534 comment 32

Comment 7

[Doug Halamay]

I'm moving to this bug from bug 278534 comment 33.

In the JS console, I'm seeing errors with ForecastFox 0.5.9 with a build I just
pulled.

The error:
Error: [Exception... "Component returned failure code: 0x8000ffff
(NS_ERROR_UNEXPECTED) [nsIPrefBranch.getCharPref]"  nsresult: "0x8000ffff
(NS_ERROR_UNEXPECTED)"  location: "JS frame ::
file:///C:/Documents%20and%20Settings/XXX/Application%20Data/Mozilla/Firefox/Profiles/default.fbk/extensions/%7B0538E3E3-7E9B-4d49-8831-A227C80A7AD3%7D/components/nsForecastfox.js
:: nsForecastfoxProfile :: line 852"  data: no]
Source File:
file:///C:/Documents%20and%20Settings/XXX/Application%20Data/Mozilla/Firefox/Profiles/default.fbk/extensions/%7B0538E3E3-7E9B-4d49-8831-A227C80A7AD3%7D/components/nsForecastfox.js
Line: 852

The chrome.manifest file contents:

overlay	chrome://browser/content/browser.xul
chrome://forecastfox/content/forecastfox.xul
content	forecastfox	jar:chrome/forecastfox.jar!/content/forecastfox/

skin	forecastfox	classic/1.0	jar:chrome/forecastfox.jar!/skin/classic/forecastfox/

locale	forecastfox	en-US	jar:chrome/forecastfox.jar!/locale/en-US/forecastfox/

locale	forecastfox	de-DE	jar:chrome/forecastfox.jar!/locale/de-DE/forecastfox/

locale	forecastfox	el-GR	jar:chrome/forecastfox.jar!/locale/el-GR/forecastfox/

locale	forecastfox	es-ES	jar:chrome/forecastfox.jar!/locale/es-ES/forecastfox/

locale	forecastfox	fr-FR	jar:chrome/forecastfox.jar!/locale/fr-FR/forecastfox/

locale	forecastfox	hr-HR	jar:chrome/forecastfox.jar!/locale/hr-HR/forecastfox/

locale	forecastfox	hu-HU	jar:chrome/forecastfox.jar!/locale/hu-HU/forecastfox/

locale	forecastfox	it-IT	jar:chrome/forecastfox.jar!/locale/it-IT/forecastfox/

locale	forecastfox	nl-NL	jar:chrome/forecastfox.jar!/locale/nl-NL/forecastfox/

locale	forecastfox	pl-PL	jar:chrome/forecastfox.jar!/locale/pl-PL/forecastfox/

locale	forecastfox	pt-BR	jar:chrome/forecastfox.jar!/locale/pt-BR/forecastfox/

locale	forecastfox	ru-RU	jar:chrome/forecastfox.jar!/locale/ru-RU/forecastfox/

locale	forecastfox	sl-SI	jar:chrome/forecastfox.jar!/locale/sl-SI/forecastfox/

locale	forecastfox	tr-TR	jar:chrome/forecastfox.jar!/locale/tr-TR/forecastfox/

locale	forecastfox	zh-CN	jar:chrome/forecastfox.jar!/locale/zh-CN/forecastfox/

I hope this helps somehow.

Comment 8

[Teune van Steeg]

Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.8b2) Gecko/20050223
Firefox/1.0+

It seems that the default prefs are not registered anymore for at least the
Duplicate Tab extension.
When I add the prefs listed in
[profile]/extensions/{61ED2A9A-39EB-4AAF-BD14-06DFBE8880C3}/defaults/preferences/duplicatetab.js
to prefs.js (as user_pref()) the error: [nsIPrefBranch.getCharPref]"  nsresult:
"0x8000ffff (NS_ERROR_UNEXPECTED)" does not show anymore and the settings in the
options dialog are remembered.


chrome.manifest:

overlay	chrome://browser/content/browser.xul
chrome://duplicatetab/content/duplicatetab.xul
overlay	chrome://browser/content/browser.xul
chrome://duplicatetab/content/duptabCAContext.xul
overlay	chrome://navigator/content/navigator.xul
chrome://duplicatetab/content/duplicatetab.xul
overlay	chrome://communicator/content/contentAreaContextOverlay.xul
chrome://duplicatetab/content/duptabCAContext.xul
content	duplicatetab	jar:chrome/duplicatetab.jar!/content/duplicatetab/

locale	duplicatetab	en-US	jar:chrome/duplicatetab.jar!/locale/en-US/duplicatetab/
locale	duplicatetab	nl-NL	jar:chrome/duplicatetab.jar!/locale/nl-NL/duplicatetab/
locale	duplicatetab	de-DE	jar:chrome/duplicatetab.jar!/locale/de-DE/duplicatetab/

I expect the same applies for ForecastFox?

Comment 9

[Bill Gianopoulos [:WG9s]]

Now that the fix for bug 278534 has re-landed, the problem with Forecastfox has
returnedin the Firefox 2005-02-23-07 nightly build.  It gets the following
errors in the JavaScript console upon startup:

Error: [Exception... "Component returned failure code: 0x8000ffff
(NS_ERROR_UNEXPECTED) [nsIPrefBranch.getIntPref]"  nsresult: "0x8000ffff
(NS_ERROR_UNEXPECTED)"  location: "JS frame ::
file:///C:/Documents%20and%20Settings/gianowa/Application%20Data/Mozilla/Firefox/Profiles/default.6hd/extensions/%7B0538E3E3-7E9B-4d49-8831-A227C80A7AD3%7D/components/nsForecastfox.js
:: anonymous :: line 1007"  data: no]
Source File:
file:///C:/Documents%20and%20Settings/gianowa/Application%20Data/Mozilla/Firefox/Profiles/default.6hd/extensions/%7B0538E3E3-7E9B-4d49-8831-A227C80A7AD3%7D/components/nsForecastfox.js
Line: 1007

Error: [Exception... "Component returned failure code: 0x80570016
(NS_ERROR_XPC_GS_RETURNED_FAILURE) [nsIJSCID.getService]"  nsresult: "0x80570016
(NS_ERROR_XPC_GS_RETURNED_FAILURE)"  location: "JS frame ::
chrome://forecastfox/content/forecastfox.js :: anonymous :: line 75"  data: no]
Source File: chrome://forecastfox/content/forecastfox.js
Line: 75


When you open the ForecastFox options from the extension manager you get the
following errors:

Error: [Exception... "Component returned failure code: 0x8000ffff
(NS_ERROR_UNEXPECTED) [nsIPrefBranch.getIntPref]"  nsresult: "0x8000ffff
(NS_ERROR_UNEXPECTED)"  location: "JS frame ::
file:///C:/Documents%20and%20Settings/gianowa/Application%20Data/Mozilla/Firefox/Profiles/default.6hd/extensions/%7B0538E3E3-7E9B-4d49-8831-A227C80A7AD3%7D/components/nsForecastfox.js
:: anonymous :: line 1007"  data: no]
Source File:
file:///C:/Documents%20and%20Settings/gianowa/Application%20Data/Mozilla/Firefox/Profiles/default.6hd/extensions/%7B0538E3E3-7E9B-4d49-8831-A227C80A7AD3%7D/components/nsForecastfox.js
Line: 1007

Error: uncaught exception: [Exception... "Component returned failure code:
0x80570016 (NS_ERROR_XPC_GS_RETURNED_FAILURE) [nsIJSCID.getService]"  nsresult:
"0x80570016 (NS_ERROR_XPC_GS_RETURNED_FAILURE)"  location: "JS frame ::
chrome://forecastfox/content/options.js :: anonymous :: line 65"  data: no]

Comment 10

[Benjamin Smedberg]

ok, I must have regressed the default-pref mechanism somehow. It's good to know
that this doesn't really have anything to do with the chrome stuff itself.

Comment 11

[Benjamin Smedberg]

Attachment: s/"pref"/"preferences"/

Comment 12

[Doug Halamay]

(In reply to comment #11)
> Created an attachment (id=175321) [edit]
> s/"pref"/"preferences"/
> 

Unfortunately, this patch doesn't seem to fix the problem.  I just ran a custom
build with this patch applied, and there was no change...same error in the JS
console.

BuildID: Mozilla/5.0 (Windows; compatible; U; Windows NT 5.1; en-US; rv:1.8b2)
Gecko/20050223 Firefox/1.0+

Comment 13

[James [silentj]]

Changing that line fixed most extensions for me in my own test build.  Some of
the tab related extensions are still hosed but i think that is to do with the
recent tab/mem leak fixes rather than the chrome stuff

Comment 14

[Richard Aspden]

Is bug 283358 related to this? It's an error on reloading Firefox after
installing extensions...

Comment 15

[Doug Halamay]

(In reply to comment #13)
> Changing that line fixed most extensions for me in my own test build.  Some of
> the tab related extensions are still hosed but i think that is to do with the
> recent tab/mem leak fixes rather than the chrome stuff

Hmmm...I went back and verified that the patch was in there, and tested it out
with a brand new profile, etc., and the problems with ForecastFox, Duplicate
Tab, and others (not necessarily tab-related at all) were still there.  The same
JS console error is still coming up.  It is intriguing that the preferences for
ForecastFox, for example, are definitely in there (you can see them in
about:config), and if you add the defaults to user.js, it works too.  But adding
the defualt preferences to user.js really doesn't seem to be an acceptable
workaround.  Something is still wrong here.

Comment 16

[Bill Gianopoulos [:WG9s]]

> Unfortunately, this patch doesn't seem to fix the problem.  I just ran a custom
> build with this patch applied, and there was no change...same error in the JS
> console.
> 
> BuildID: Mozilla/5.0 (Windows; compatible; U; Windows NT 5.1; en-US; rv:1.8b2)
> Gecko/20050223 Firefox/1.0+

Same results here.  Pulled fresh source, applied this patch and Forecast still
will not run and gets the same JavaScript errors upon launch as without the
patch.(In reply to comment #12)

Comment 17

[Bill Gianopoulos [:WG9s]]

Attachment: take 2

Changing "pref" to "preferences at one additiona location fixes the problem.

Comment 18

[Bill Gianopoulos [:WG9s]]

Attachment: fix editing screwup in previous patch

I had edited the patch file and had botched it.  Same code, just the patch file
is correct now.

Comment 19

[Ryan VanderMeulen [:RyanVM]]

(In reply to comment #18)
> Created an attachment (id=175424) [edit]
> fix editing screwup in previous patch
> 
> I had edited the patch file and had botched it.  Same code, just the patch file
> is correct now.

Confirming that this patch fixes the issues I was having. Forecastfox works again :)

Comment 20

[Benjamin Smedberg]

Comment on attachment 175424 [details] [diff] [review]
fix editing screwup in previous patch

This actually changes the structure of xulapps a bit, but that's good, we want
them to match extensions. I will land this with build-config fixup in the
sample xulapp.

Comment 21

[Doug Halamay]

(In reply to comment #19)
> (In reply to comment #18)
> > Created an attachment (id=175424) [edit] [edit]
> > fix editing screwup in previous patch
> > 
> > I had edited the patch file and had botched it.  Same code, just the patch 
file
> > is correct now.
> Confirming that this patch fixes the issues I was having. Forecastfox works 
again :)

I can verify that this patch fixes the problem.

Comment 22

[Worcester12345]

Downloaded a "beast" Firefox build, and Forecastfox now working (just in time
for another big snow dump!). Tabs also close seemingly correctly, but not sure
if that is a separate bug.

Comment 23

[Peter van der Woude [:Peter6]]

Mozilla/5.0 (Windows; U; Windows NT 5.0; en-US; rv:1.8b2) Gecko/20050224
Firefox/1.0+ 13:44PST (last patch included)

crashed the first time I tried to reorder my tabs (using MiniT drag+indicator)
Tried again and didn't manage to crash again

-> TB3915773E
(for what it might be worth)

Comment 24

[Benjamin Smedberg]

The pref stuff is fixed; any tab problems are not this bug.