282863 - talkback symbols clash when they have the same build id

Status: RESOLVED WONTFIX

(SeaMonkey :: Build Config, defect)

Description

[Mats Palmgren (inactive)]

GTK1 and GTK2 talkback symbols clash when they have the same build id.

(spawned off from bug 282397)

I tried 2005-02-19-05 GTK1 installer build and it works:
ftp://ftp.mozilla.org/pub/mozilla.org/mozilla/nightly/2005-02-19-06-trunk/mozilla-i686-pc-linux-gnu-full-installer.tar.gz
http://talkback-public.mozilla.org/talkback/fastfind.jsp?search=2&type=iid&id=tb3805000g

2005-02-19-02 GTK2 build from same directory also works:
http://talkback-public.mozilla.org/talkback/fastfind.jsp?search=2&type=iid&id=tb3805165h


Now try 2005-02-17-12 GTK1 and GTK2 builds:

GTK1 stack is incorrect:
http://ftp.mozilla.org/pub/mozilla.org/mozilla/nightly/2005-02-17-14-trunk/mozilla-i686-pc-linux-gnu-full-installer.tar.gz
http://talkback-public.mozilla.org/talkback/fastfind.jsp?search=2&type=iid&id=tb3805320k

GTK2 stack is correct:
http://ftp.mozilla.org/pub/mozilla.org/mozilla/nightly/2005-02-17-16-trunk/mozilla-i686-pc-linux-gnu-gtk2+xft.tar.gz
http://talkback-public.mozilla.org/talkback/fastfind.jsp?search=2&type=iid&id=tb3805309w

I used bug 282714 in all cases to trigger the crash.

Comment 1

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

Yeah, this is why we have the GTK2 builds happen earlier in the day than the
GTK1 builds. :-)

Comment 2

[Chase Phillips]

Mass reassign of open bugs for [e-mail] to [e-mail].

Comment 3

[Robert Helmer [:rhelmer]]

We are no longer producing GTK1 builds for end-user consumption (only for testing purposes). Can this be closed?

Comment 4

[Boris Zbarsky [:bzbarsky]]

We're still producing nightlies, which means that every so often (whenever the GTK2 and GTK1 nightlies happen at the same time) talkback will have issues.  I can't tell you whether it'll always be broken for the GTK1 builds or sometimes for the GTK2 builds; I suspect it'll be broken for whichever ones builds slightly earlier.

If we guarantee that the two sets of builds always happen at different times, then there's no problem, but given the scatter in timestamps on the FTP site, I'm not sure we guarantee that now.

Comment 5

[Robert Helmer [:rhelmer]]

(In reply to comment #4)
> We're still producing nightlies, which means that every so often (whenever the
> GTK2 and GTK1 nightlies happen at the same time) talkback will have issues.  I
> can't tell you whether it'll always be broken for the GTK1 builds or sometimes
> for the GTK2 builds; I suspect it'll be broken for whichever ones builds
> slightly earlier.
> 
> If we guarantee that the two sets of builds always happen at different times,
> then there's no problem, but given the scatter in timestamps on the FTP site,
> I'm not sure we guarantee that now.

Do we need to still publish GTK1 nightlies, and if so why? The test tinderboxes can just build and not publish if we want them to.

Also this bug is on Suite, which we are going to stop building Real Soon Now.
Does this affect other products as well?

Comment 6

[Boris Zbarsky [:bzbarsky]]

> Do we need to still publish GTK1 nightlies, and if so why?

For trunk, imo no.  But that's not really my call, so...

> Also this bug is on Suite, which we are going to stop building Real Soon Now.

It also affects Seamonkey, of course.  This _is_ the bugzilla product for Seamonkey issues, last I checked.

> Does this affect other products as well?

If we produce multiple variants of builds all with talkback enabled for the same OS for those products, I'd guess the answer is "yes".

Comment 7

[Jay Patel [:jay]]

Chase and I talked about this a while back, and if you want Talkback for 2 types of builds on the same platform, the only feasible way to differentiate them is to have a unique build id (don't want to mess with Talkback vendor, product, platform ids).  That can be done in a number of ways, but the two best options are:

1. Expand the current dated build id to include the hour and seconds (not sure why we have not done this yet anyway)
2. Add a string to the end of the current 10 digit Talkback build id to identify which type of build it is (gtk1/gtk2, ppc/ub, etc).  This will most likely break a lot of my reporting scripts for Talkback data, but with some work, we can work around this.

If neither of those are an option, I'll let the build gods figure it out.

Comment 8

[Mats Palmgren (inactive)]

Gtk1 widget code has been removed on trunk but the problem is generic
so I'm leaving the bug open.

Comment 9

[Boris Zbarsky [:bzbarsky]]

John, why is this wontfix, exactly?  Is this definitely not a problem with breakpad?

Comment 10

[(not currently active) Ted Mielczarek]

We implemented a workaround for this in bug 382172, we're using it with the textframe builds, but for Breakpad symbols it's only really a problem for cleanup purposes, as the symbols themselves will not clash.

Comment 11

[Boris Zbarsky [:bzbarsky]]

I guess the real question is whether there's a bug still here. If yes, I think we should fix it....  The sort of thing we're doing with textframe shouldn't be needed, imo.

Comment 12

[Benjamin Smedberg]

This is not a problem with breakpad because of the extra unique identifier. There are several bugs about making the buildid better in general, but this one (which is about talkback anyway) is irrelevant.