282893 - Properly indent children in help files especially <div>

Status: RESOLVED FIXED

(Documentation Graveyard :: Help Viewer, defect)

Description

[Ian Neal]

Both composer_help.xhtml and nav_help.xhtml do not seem to indent the children
of <div> correctly. Spun off from bug 282783.

Comment 1

[Ian Neal]

Other associated indentation tidy up of composer_help and nav_help could
probably be done at the same time.

Comment 2

[Giacomo Magnini]

Attachment: Taking care of composer: 80 cols format, indentation fixes, removal of <blockquote> (used only here once). No word changes.

Comment 3

[Giacomo Magnini]

Attachment: Complete file, for easier reading...

Comment 4

[Ian Neal]

Comment on attachment 174834 [details] [diff] [review]
Taking care of composer: 80 cols format, indentation fixes, removal of <blockquote> (used only here once). No word changes.

>Index: en-US/composer_help.xhtml
>===================================================================
.
.
> <ol>
>   <li>Open the Window menu and choose Navigator.</li>
>   <li>Go to a web page: type the URL of the page (for example,
>     <tt>http://www.mozilla.org</tt>) in the Location Bar and press
>       <kbd class="mac">Return</kbd><kbd class="noMac">Enter</kbd>.</li>
>   <li>Open the File menu and choose Edit Page.</li>
> </ol>
<kbd> indented too far?

.
.
>+  <li>Open the Format menu and choose one of the following:
>+    <ul>
>+      <li><strong>Font</strong>: Use this to choose a font. If you prefer to
>+      use fonts specified by the reader&apos;s browser, select Variable Width
>+      or Fixed Width.
Needs indenting.

.
.
>-<p id="subdir_not_found"><strong>Error Message:</strong></p>
>+  <p id="subdir_not_found"><strong>Error Message:</strong></p>
> 
>-<div class="contentsBox" style="background-color: #ebebeb;">
>-  <tt>The subdirectory <var>directory name</var> doesn&apos;t exist on this site or the filename
>-  <var>filename</var> is already in use by another subdirectory</tt>
>-  <p>or</p>
>-  <tt>The filename <var>filename</var> is already in use by another subdirectory</tt>
>-</div>
>+  <div class="contentsBox" style="background-color: #ebebeb;">
>+    <tt>The subdirectory <var>directory name</var> doesn&apos;t exist on this
>+    site or the filename <var>filename</var> is already in use by another
>+    subdirectory</tt>
Needs to be indented.

r= with those changes

Comment 5

[Giacomo Magnini]

Attachment: rev2. Carrying over flag. (Checked in)

Comment 6

[Giacomo Magnini]

Attachment: nav_help part. Some reformat to 80 cols and removed a useless <div> for proxy (also fixing the entry in help-toc.rdf)

Comment 7

[Giacomo Magnini]

btw, please morph the bug into something more useful: there are so many of
out-of-format files that sooner or later we (or I...) should address them all,
one by one.

Comment 8

[Giacomo Magnini]

Attachment: I hate this... Can't remove h1 since proxy is referenced by the main section. Still, I think the div in there is deletable.

Comment 9

[Ian Neal]

Tweaking summary - old summary was "Properly indent children of <div> in help files"

Comment 10

[Ian Neal]

Comment on attachment 174852 [details] [diff] [review]
I hate this... Can't remove h1 since proxy is referenced by the main section. Still, I think the div in there is deletable.

>Index: en-US/nav_help.xhtml
>===================================================================
.
.
> <h2 id="making_mozilla_your_default_browser">Making &brandShortName; Your
>   Default Browser</h2>
> 
> <p class="noWin">This feature is not available on your system.</p>
> 
> <div class="win">
You need to indent after this <div> also for the other <div class="win">s.

>@@ -1605,17 +1605,18 @@ search, and save web pages.</p>
> 
> <ol>
>   <li>Open the
>     <span class="mac">&brandShortName;</span> <span class="noMac">Edit</span>
>     menu and choose Preferences.</li>
>   <li>Under the Advanced category, click Cache. (If no subcategories are
>     visible, double-click Advanced to expand the list.)</li>
>   <li>Enter a number in the Size field to specify the size of the cache.
>-    50 MB is sufficient. To clear the cache immediately, click Clear Cache.</li>
>+    50 MB is sufficient. To clear the cache immediately, click Clear Cache.
>+  </li>
I presume this is for the 80 column. Can the 50 be moved up to the line before
so that the </li> fits at the end of the line rather than changing the style.

>@@ -1729,36 +1730,25 @@ search, and save web pages.</p>
.
.
> <p>[<a href="#improving_speed_and_efficiency">Return to beginning of
>   section</a>]</p>
> </div>
> 
> <h1 id="proxies">Proxies</h1>
> 
>-<div class="contentsBox">In this section:
>-<ul>
>-  <li><a href="#setting_proxy_values">Setting Proxy Values</a></li>
>-</ul>
>-</div>
>-
>-<p>This section explains how to work with proxies.</p>
>-
>-<h2 id="setting_proxy_values">Setting Proxy Values</h2>
>-
I'm not sure I want this change in at the moment.

>@@ -1816,14 +1806,12 @@ search, and save web pages.</p>
>   washington.org. If you use local host names without the domain name, list
>   them the same way. Use commas to separate multiple host names. The wildcard
>   character [*] cannot be used.</p>
> 
> <p>For more information on using the Proxy preferences panel, see
>   <a href="cs_nav_prefs_advanced.xhtml#proxies">Advanced Preferences -
>   Proxies</a>.</p>
> 
>-<p>[<a href="#proxies">Return to beginning of section</a>]</p>
>-
As above.

>Index: en-US/help-toc.rdf
>===================================================================
>@@ -129,24 +129,16 @@ nc:link="chrome://help/locale/nav_help.x
.
.
>-  <rdf:Description about="#nav-proxies">
>-    <nc:subheadings>
>-      <rdf:Seq>
>-        <rdf:li> <rdf:Description ID="nav-prox" nc:name="Setting Proxy Values" nc:link="nav_help.xhtml#setting_proxy_values"/> </rdf:li>
>-      </rdf:Seq>
>-    </nc:subheadings>
>-  </rdf:Description>
>-
As above.

I think I would be happier with Proxy <div> removal being spun off into a
different bug and patch.

Comment 11

[Ian Neal]

Comment on attachment 174840 [details] [diff] [review]
rev2. Carrying over flag. (Checked in)

Checking in composer_help.xhtml;
/cvsroot/mozilla/extensions/help/resources/locale/en-US/composer_help.xhtml,v 
<--  composer_help.xhtml
new revision: 1.29; previous revision: 1.28
done

Comment 12

[Giacomo Magnini]

Attachment: Nits addressed, fixed a real syntax error (ul inside a p).

Comment 13

[Giacomo Magnini]

I've made some tweaks to mail_help.xhtml to let it validate as xhtml 1.1 (which
it does not currently), but I haven't touched the formatting (5.2K lines of
formatting? Not yet). Should I open a new bug for that?
Stefan or I should also open a bug for removal of ', now that it's no
longer needed: any thoughts?

Comment 14

[Giacomo Magnini]

Attachment: forgot to indent a second div=win...

Comment 15

[Ian Neal]

Comment on attachment 174973 [details] [diff] [review]
forgot to indent a second div=win...

>Index: en-US/nav_help.xhtml
>===================================================================
>@@ -771,34 +773,34 @@ search, and save web pages.</p>
> <ul>
>   <li>Double-click a bookmark in the Search Results window to go to that web
>   page.</li>
Needs indenting.

There's a <div> starting at line 1063 that needs indenting too:
<div class="contentsBox">In this section:

Starting at line 1113, more indentation needs fixing:
<ol>
  <li>Open the View menu, choose Character Encoding, and then choose
    Auto-Detect.</li>
 <li>Choose one of the Auto-Detect options, or choose Off from the
   submenu.</li>
</ol>

>@@ -1243,17 +1243,18 @@ search, and save web pages.</p>
.
.
> <div class="contentsBox">In this section:
This <div>'s children need indenting too.

Starting at line 1347 to 1387, the three <ol>s are too far indented:
    <p id="adding_a_new_helper_application">To add a new helper application
      to the list:</p>

      <ol>
	<li>Click New Type. You see the New type dialog box.</li>

Comment 16

[Giacomo Magnini]

Attachment: Fixed nits. (Checked in)

Comment 17

[Giacomo Magnini]

Attachment: cert_dialog_help.xhtml cleanup

Comment 18

[Giacomo Magnini]

Attachment: certs, certs_prefs, cs_nav_prefs_*, cs_priv_prefs_popup, devtools, forieusers 80cols and indentation fixes

Comment 19

[Ian Neal]

Comment on attachment 175123 [details] [diff] [review]
Fixed nits. (Checked in)

Checking in nav_help.xhtml;
/cvsroot/mozilla/extensions/help/resources/locale/en-US/nav_help.xhtml,v  <-- 
nav_help.xhtml
new revision: 1.51; previous revision: 1.50
done

Comment 20

[Ian Neal]

Comment on attachment 175125 [details] [diff] [review]
cert_dialog_help.xhtml cleanup

>Index: en-US/cert_dialog_help.xhtml
>===================================================================
>@@ -32,454 +37,513 @@
.
.
> <ol>
>    <li>Open the <span class="mac">&brandShortName;</span>
>      <span class="noMac">Edit</span> menu and choose Preferences.</li>
>    <li>Under the Privacy &amp; Security category, click Certificates. (If no
>-     subcategories are visible, double-click Privacy &amp; Security to expand the list.)</li>
>+     subcategories are visible, double-click Privacy &amp; Security to expand
>+     the list.)</li>
>    <li>Click Manage Certificates.</li>
>-   <li>Click the tab for the type of certificate whose details you want to view.</li>
>+   <li>Click the tab for the type of certificate whose details you want to
>+     view.</li>
>    <li>Select the certificate whose details you want to view.</li>
>    <li>Click View.</li>
> </ol>
All the <li>s are indented one space too many.

.
.
>+<p>Like any other valuable data, certificates should be backed up to avoid
>+  future  trouble and expense. Do it now so you don&apos;t forget.</p>
Two spaces instead of one between "future" and "trouble".

.
.
> <ol>
>    <li>Open the <span class="mac">&brandShortName;</span>
>      <span class="noMac">Edit</span> menu and choose Preferences.</li>
>-   <li>Under the Privacy &amp; Security category, click Certificates. (If no subcategories
>-     are visible, double-click Privacy &amp; Security to expand the list.)</li>
>+   <li>Under the Privacy &amp; Security category, click Certificates. (If no
>+     subcategories are visible, double-click Privacy &amp; Security to expand
>+     the list.)</li>
>    <li>Click Manage Certificates.</li>
>    <li>Click the Authorities tab.</li>
>    <li>Select the CA certificate whose trust settings you want to edit.</li>
>    <li>Click the Edit button and select the appropriate trust settings.</li>
> </ol>
All the <li>s are indented one space too many.

Comment 21

[Ian Neal]

Comment on attachment 175126 [details] [diff] [review]
certs, certs_prefs, cs_nav_prefs_*, cs_priv_prefs_popup, devtools,  forieusers 80cols and indentation fixes

>Index: en-US/certs_help.xhtml
>===================================================================
>@@ -1,30 +1,30 @@
.
.
> <p>This section describes how to use the Certificate Manager. For more
> information on using certificates, see <a href="using_certs_help.xhtml">Using
> Certificates</a>.</p>
This needs indenting.
> 
> <p>If you are not currently viewing the Certificate Manager window, follow
This needs indenting too.

There is an <ol> that needs indenting starting at line 33.
There is a <div> that needs indenting starting at line 42.
There is a <ul> that needs indenting starting at line 60.
There is a <ul> that needs indenting starting at line 71.
There is a <ul> that needs indenting starting at line 83.

>@@ -112,77 +112,78 @@ their names.</li>
> <p>The Certificate Manager asks you to set this password when you back up
>   certificates, and requests it when you attempt to import certificates that
>   have previously been backed up.</p>
> 
> <ul>
> <li><strong>Certificate backup password:</strong> Type your backup password
>   into this field.</li>
> <li><strong>Certificate backup password (again):</strong> Type your backup
>-  password again. If you don&apos;t type it the second time exactly as you did the
>-  first time, the OK button remains inactive. If this happens, try typing the
>-  new password again.</li>
>+  password again. If you don&apos;t type it the second time exactly as you did
>+  the first time, the OK button remains inactive. If this happens, try typing
>+  the new password again.</li>
> </ul>
This <ul> needs indenting.

>Index: en-US/certs_prefs_help.xhtml
>===================================================================
There is an <ol> that's children are indented one space too many starting at
line 40.

>Index: en-US/cs_nav_prefs_advanced.xhtml
>===================================================================
There is a <div> that needs indenting starting at line 28.
There is a <div> that needs indenting starting at line 494.

>Index: en-US/cs_nav_prefs_navigator.xhtml
>===================================================================
There is a <div> that needs indenting starting at line 28.

>Index: en-US/cs_priv_prefs_popup.xhtml
>===================================================================
This one is fine.

>Index: en-US/developer_tools.xhtml
>===================================================================
This one is fine too.

>Index: en-US/forieusers.xhtml
>===================================================================
This one is fine too.

Comment 22

[Stefan [:stefanh]]

--> Giacomo

Comment 23

[Giacomo Magnini]

Attachment: Nits fixed - cert_dialog_help fixes (Checked in)

Comment 24

[Giacomo Magnini]

Attachment: More nits fixed. :) - certs, certs_prefs, cs_nav_prefs_*, cs_priv_prefs_popup, devtools, forieusers 80cols and indentation fixes (Checked in)

Comment 25

[Ian Neal]

Comment on attachment 175766 [details] [diff] [review]
Nits fixed - cert_dialog_help fixes (Checked in)

Checking in cert_dialog_help.xhtml;
/cvsroot/mozilla/extensions/help/resources/locale/en-US/cert_dialog_help.xhtml,
v  <--	cert_dialog_help.xhtml
new revision: 1.14; previous revision: 1.13
done

Comment 26

[Ian Neal]

Comment on attachment 175767 [details] [diff] [review]
More nits fixed. :) - certs, certs_prefs, cs_nav_prefs_*, cs_priv_prefs_popup, devtools, forieusers 80cols and indentation fixes (Checked in)

Checking in certs_help.xhtml;
/cvsroot/mozilla/extensions/help/resources/locale/en-US/certs_help.xhtml,v  <--
 certs_help.xhtml
new revision: 1.44; previous revision: 1.43
done
Checking in certs_prefs_help.xhtml;
/cvsroot/mozilla/extensions/help/resources/locale/en-US/certs_prefs_help.xhtml,
v  <--	certs_prefs_help.xhtml
new revision: 1.27; previous revision: 1.26
done
Checking in cs_nav_prefs_advanced.xhtml;
/cvsroot/mozilla/extensions/help/resources/locale/en-US/cs_nav_prefs_advanced.x
html,v	<--  cs_nav_prefs_advanced.xhtml
new revision: 1.39; previous revision: 1.38
done
Checking in cs_nav_prefs_navigator.xhtml;
/cvsroot/mozilla/extensions/help/resources/locale/en-US/cs_nav_prefs_navigator.
xhtml,v  <--  cs_nav_prefs_navigator.xhtml
new revision: 1.27; previous revision: 1.26
done
Checking in cs_priv_prefs_popup.xhtml;
/cvsroot/mozilla/extensions/help/resources/locale/en-US/cs_priv_prefs_popup.xht
ml,v  <--  cs_priv_prefs_popup.xhtml
new revision: 1.10; previous revision: 1.9
done
Checking in developer_tools.xhtml;
/cvsroot/mozilla/extensions/help/resources/locale/en-US/developer_tools.xhtml,v
 <--  developer_tools.xhtml
new revision: 1.6; previous revision: 1.5
done
Checking in forieusers.xhtml;
/cvsroot/mozilla/extensions/help/resources/locale/en-US/forieusers.xhtml,v  <--
 forieusers.xhtml
new revision: 1.13; previous revision: 1.12
done

Comment 27

[Giacomo Magnini]

Attachment: Glossary and help_help (Checked in)

Comment 28

[Giacomo Magnini]

Attachment: mail_sec, page_info, passwords, profiles (Checked in with nits addressed)

Comment 29

[Giacomo Magnini]

Attachment: privacy, privsec, ssl, using_certs

Comment 30

[Giacomo Magnini]

Attachment: using_priv, validation, welcome

Comment 31

[Giacomo Magnini]

Attachment: Minor tweaks to customize, mail (image alignment) and shortcuts. (Checked in)

Comment 32

[Stefan [:stefanh]]

Are those 5 patches supposed to be reviewed? :)

Comment 33

[Giacomo Magnini]

(In reply to comment #32)
> Are those 5 patches supposed to be reviewed? :)

They will be scrutinized by Ian as he finds some time: we decided for this route
over IRC so I don't flood him with r? and I get it right (hopefully) faster.
They will come, be assured! :) Oh, and I address your nit in another bug for the
images in mail_help (sort of). Talking about that file, I'm around line 1800: we
gained around 300 lines and wasted some 5KB in spaces... ;)

Comment 34

[Stefan [:stefanh]]

(In reply to comment #33)
> (In reply to comment #32)
> > Are those 5 patches supposed to be reviewed? :)
> 
> They will be scrutinized by Ian as he finds some time: we decided for this route
> over IRC so I don't flood him with r? and I get it right (hopefully) faster.
> They will come, be assured! :) Oh, and I address your nit in another bug for the
> images in mail_help (sort of). Talking about that file, I'm around line 1800: we
> gained around 300 lines and wasted some 5KB in spaces... ;)

Ah, great job Giacomo :)

Comment 35

[Ian Neal]

Comment on attachment 175797 [details] [diff] [review]
Glossary and help_help (Checked in)

Checking in glossary.xhtml;
/cvsroot/mozilla/extensions/help/resources/locale/en-US/glossary.xhtml,v  <-- 
glossary.xhtml
new revision: 1.40; previous revision: 1.39
done
Checking in help_help.xhtml;
/cvsroot/mozilla/extensions/help/resources/locale/en-US/help_help.xhtml,v  <-- 
help_help.xhtml
new revision: 1.22; previous revision: 1.21
done

Comment 36

[Ian Neal]

Comment on attachment 175798 [details] [diff] [review]
mail_sec, page_info, passwords, profiles (Checked in with nits addressed)

>Index: en-US/mail_sec_help.xhtml
>===================================================================
This file is fine.

>Index: en-US/page_info_help.xhtml
>===================================================================
This file is fine.

>Index: en-US/passwords_help.xhtml
>===================================================================
>@@ -165,17 +164,17 @@
> 
>     <p>If you remove an entry from this list, Password Manager will again ask
>       you, the next time you log onto the site, whether to store your user name
>       and password.</p>
>   </li>
> </ol>
> 
> <p>Regardless of which tab you are viewing, you can remove entries from the
>-list as follows:</p>
>+  list as follows:</p>
> 
> <ul>
>   <li><strong>Remove:</strong> Select one or more entries that you want to
>     remove, then click Remove.</li>
>   <li><strong>Remove All:</strong> Click this button to remove all the entries
>   listed in the tab you are viewing.</li>
This needed indenting.

>Index: en-US/profiles_help.xhtml
>===================================================================
At line 161 there is <p> that needed indenting.

With those changed r=

Checking in mail_sec_help.xhtml;
/cvsroot/mozilla/extensions/help/resources/locale/en-US/mail_sec_help.xhtml,v 
<--  mail_sec_help.xhtml
new revision: 1.29; previous revision: 1.28
done
Checking in page_info_help.xhtml;
/cvsroot/mozilla/extensions/help/resources/locale/en-US/page_info_help.xhtml,v 
<--  page_info_help.xhtml
new revision: 1.17; previous revision: 1.16
done
Checking in passwords_help.xhtml;
/cvsroot/mozilla/extensions/help/resources/locale/en-US/passwords_help.xhtml,v 
<--  passwords_help.xhtml
new revision: 1.39; previous revision: 1.38
done
Checking in profiles_help.xhtml;
/cvsroot/mozilla/extensions/help/resources/locale/en-US/profiles_help.xhtml,v 
<--  profiles_help.xhtml
new revision: 1.20; previous revision: 1.19
done

Comment 37

[Ian Neal]

Comment on attachment 175799 [details] [diff] [review]
privacy, privsec, ssl, using_certs

>Index: en-US/privacy_help.xhtml
>===================================================================
>@@ -33,50 +33,50 @@
.
.
> <div class="contentsBox">In this section:
>-<ul>
>-<li><a href="#what_information_does_my_browser_give_to_a_web_site">What
>-  Information Does My Browser Give to a Web Site?</a></li>
>-<li><a href="#what_are_cookies_and_how_do_they_work">What Are Cookies, and How
>-  Do They Work?</a></li>
>-<li><a href="#how_can_i_control_web_pages_in_email_messages">How Can I Control
>-  Web Pages in Email Messages?</a></li>
>-<li><a href="#how_do_i_make_sure_unauthorized_people_dont_use_information_about_me">How
>-  Can I Make Sure Unauthorized People Don&apos;t Use Information About Me?</a></li>
>-</ul>
>+  <ul>
>+  <li><a href="#what_information_does_my_browser_give_to_a_web_site">What
>+    Information Does My Browser Give to a Web Site?</a></li>
>+  <li><a href="#what_are_cookies_and_how_do_they_work">What Are Cookies, and
>+    How Do They Work?</a></li>
>+  <li><a href="#how_can_i_control_web_pages_in_email_messages">How Can I
>+    Control Web Pages in Email Messages?</a></li>
>+  <li><a href="#how_do_i_make_sure_unauthorized_people_dont_use_information_about_me">How
>+    Can I Make Sure Unauthorized People Don&apos;t Use Information About
>+    Me?</a></li>
>+  </ul>
> </div>
You have not indented the <li>s enough.

>Index: en-US/privsec_help.xhtml
>===================================================================
>@@ -25,24 +24,24 @@
>    <li>Click the Privacy &amp; Security category. If no subcategories are
>      visible, double-click Privacy &amp; Security to expand the list, then
>      click the name for the preferences you want to view or change.</li>
> </ol>
> 
> <p>For help with a panel&apos;s settings, click the appropriate link below.</p>
> 
> <div class="contentsBox">Related sections:
>-<ul>
>-  <li><a href="using_priv_help.xhtml#cookies">Cookies</a></li>
>-  <li><a href="using_priv_help.xhtml#images">Images</a></li>
>-  <li><a href="using_priv_help.xhtml#forms">Forms</a></li>
>-  <li><a href="passwords_help.xhtml">Passwords</a></li>
>-  <li><a href="passwords_help.xhtml#master_passwords">Master Passwords</a></li>
>-  <li><a href="ssl_help.xhtml">SSL</a></li>
>-  <li><a href="certs_prefs_help.xhtml">Certificates</a></li>
>-  <li><a href="validation_help.xhtml">Validation</a></li>
>-</ul>
>+ <ul>
You need to indent the <ul> by one more space.

>Index: en-US/ssl_help.xhtml
>===================================================================
There is the children of a <div> starting at line 21 that need indenting.


>Index: en-US/using_certs_help.xhtml
>===================================================================
There is a <p> that needs indenting at line 212.
There is a <h1> that needs indenting at line 487.

Comment 38

[Ian Neal]

Comment on attachment 175800 [details] [diff] [review]
using_priv, validation, welcome

>Index: en-US/using_priv_help.xhtml
>===================================================================
>@@ -229,23 +229,23 @@
> <p>This section describes how to set your Cookies preferences and control other
>   aspects of cookie handling.</p>
> 
> <p>For step-by-step descriptions of various tasks related to cookies, see
>   <a href="#using_the_cookie_manager">Using the Cookie
>   Manager</a>.</p>
> 
> <div class="contentsBox">In this section:
>-<ul>
>-  <li><a href="#cookies">Privacy &amp; Security Preferences - Cookies</a></li>
>-  <li><a href="#stored_cookies">Stored Cookies</a></li>
>-  <li><a href="#cookie_sites">Cookie Sites</a></li>
>-  <li><a href="#privacy_settings">Privacy Settings</a></li>
>-  <li><a href="#cookie_notification">Cookie Notification</a></li>
>-</ul>
>+  <ul>
>+   <li><a href="#cookies">Privacy &amp; Security Preferences - Cookies</a></li>
>+    <li><a href="#stored_cookies">Stored Cookies</a></li>
>+    <li><a href="#cookie_sites">Cookie Sites</a></li>
>+    <li><a href="#privacy_settings">Privacy Settings</a></li>
>+    <li><a href="#cookie_notification">Cookie Notification</a></li>
>+  </ul>
One <li> needs an extra space.

There are the children of a <div> starting at line 647 that need indenting.

Missing <p> and </p> from around "Return to beginning of section" link.

>Index: en-US/validation_help.xhtml
>===================================================================
Too big a gap at line 54, perhaps also at 115 and 234?

>Index: en-US/welcome_help.xhtml
>===================================================================
This file is fine.

Comment 39

[Ian Neal]

Comment on attachment 175804 [details] [diff] [review]
Minor tweaks to customize, mail (image alignment) and shortcuts. (Checked in)

Checking in mail_help.xhtml;
/cvsroot/mozilla/extensions/help/resources/locale/en-US/mail_help.xhtml,v  <-- 
mail_help.xhtml
new revision: 1.56; previous revision: 1.55
done
Checking in customize_help.xhtml;
/cvsroot/mozilla/extensions/help/resources/locale/en-US/customize_help.xhtml,v 
<--  customize_help.xhtml
new revision: 1.43; previous revision: 1.42
done
Checking in shortcuts.xhtml;
/cvsroot/mozilla/extensions/help/resources/locale/en-US/shortcuts.xhtml,v  <-- 
shortcuts.xhtml
new revision: 1.15; previous revision: 1.14
done

Comment 40

[Ian Neal]

Comment on attachment 175804 [details] [diff] [review]
Minor tweaks to customize, mail (image alignment) and shortcuts. (Checked in)

customize_help.xhtml still needs more work I count at least 7 <div>s that need
their children indenting.

Comment 41

[Giacomo Magnini]

Attachment: Nits fixed - privacy, privsec, ssl, using_certs (Checked in)

Comment 42

[Giacomo Magnini]

Attachment: Again, fixed nits - using_priv, validation, welcome (Checked in)

Comment 43

[Giacomo Magnini]

Attachment: Additional work for composer

Comment 44

[Ian Neal]

Comment on attachment 175903 [details] [diff] [review]
Nits fixed - privacy, privsec, ssl, using_certs (Checked in)

Checking in privacy_help.xhtml;
/cvsroot/mozilla/extensions/help/resources/locale/en-US/privacy_help.xhtml,v 
<--  privacy_help.xhtml
new revision: 1.40; previous revision: 1.39
done
Checking in privsec_help.xhtml;
/cvsroot/mozilla/extensions/help/resources/locale/en-US/privsec_help.xhtml,v 
<--  privsec_help.xhtml
new revision: 1.33; previous revision: 1.32
done
Checking in ssl_help.xhtml;
/cvsroot/mozilla/extensions/help/resources/locale/en-US/ssl_help.xhtml,v  <-- 
ssl_help.xhtml
new revision: 1.34; previous revision: 1.33
done
Checking in using_certs_help.xhtml;
/cvsroot/mozilla/extensions/help/resources/locale/en-US/using_certs_help.xhtml,
v  <--	using_certs_help.xhtml
new revision: 1.47; previous revision: 1.46
done

Comment 45

[Ian Neal]

Comment on attachment 175904 [details] [diff] [review]
Again, fixed nits - using_priv, validation, welcome (Checked in)

Checking in using_priv_help.xhtml;
/cvsroot/mozilla/extensions/help/resources/locale/en-US/using_priv_help.xhtml,v
 <--  using_priv_help.xhtml
new revision: 1.53; previous revision: 1.52
done
Checking in validation_help.xhtml;
/cvsroot/mozilla/extensions/help/resources/locale/en-US/validation_help.xhtml,v
 <--  validation_help.xhtml
new revision: 1.32; previous revision: 1.31
done
Checking in welcome_help.xhtml;
/cvsroot/mozilla/extensions/help/resources/locale/en-US/welcome_help.xhtml,v 
<--  welcome_help.xhtml
new revision: 1.19; previous revision: 1.18
done

Comment 46

[Ian Neal]

Comment on attachment 175906 [details] [diff] [review]
Additional work for composer

Did you attach the right patch?

Comment 47

[Giacomo Magnini]

(In reply to comment #46)
> (From update of attachment 175906 [details] [diff] [review] [edit])
> Did you attach the right patch?

Seems so, in reply to comment 40 (exactly 7 divs to indent plus a few more
nits). I can't seem to find what's wrong with this...
Btw, when I'm done, I'll attach the complete mail_help.xhtml for review, since
the patch will be around 3-400K I guess... :(
 

Comment 48

[Giacomo Magnini]

Attachment: Complete mail_help.xhtml for review. Deleted around 800 empty lines, added around 9KB of spaces... :(

Comment 49

[Giacomo Magnini]

(In reply to comment #43)
> Created an attachment (id=175906) [edit]
> Additional work for composer

Now I get it: this is actually customize, not composer! :)

Comment 50

[Giacomo Magnini]

Attachment: Aditional work for customize_help (Checked in)

Comment 51

[Ian Neal]

Comment on attachment 176051 [details] [diff] [review]
Aditional work for customize_help (Checked in)

Checking in customize_help.xhtml;
/cvsroot/mozilla/extensions/help/resources/locale/en-US/customize_help.xhtml,v 
<--  customize_help.xhtml
new revision: 1.44; previous revision: 1.43
done

Comment 52

[Ian Neal]

Comment on attachment 176021 [details]
Complete mail_help.xhtml for review. Deleted around 800 empty lines, added around 9KB of spaces... :(

Children of <table> starting at line 39 need indenting.
Extra space between [ and < at lines 533, 568, 1029, 1327 and 4627.
<ul> and its children are indented too far starting line 643.
I would still like to have the diff of this file.

Comment 53

[Stefan [:stefanh]]

(In reply to comment #52)
> (From update of attachment 176021 [details] [edit])
> Children of <table> starting at line 39 need indenting.
> Extra space between [ and < at lines 533, 568, 1029, 1327 and 4627.
> <ul> and its children are indented too far starting line 643.
> I would still like to have the diff of this file.
>


<p>Copyright &copy; 2003-2005 The Mozilla Foundation.</p>
</body>
</html>

Missing blank line between <p>...</> and </body> ;)

Comment 54

[Giacomo Magnini]

Attachment: You asked for it... :) mail_help diff with already reported (picky :) ) nits fixed (Checked in)

Comment 55

[Stefan [:stefanh]]

Hmm, using_priv_help still has a transitional doctype... do you mind fixing that
as well?

Comment 56

[Giacomo Magnini]

Attachment: As Stefan asked - using_priv_help to xhtml 1.1 (Checked in)

Comment 57

[Ian Neal]

Comment on attachment 176121 [details] [diff] [review]
You asked for it... :) mail_help diff with already reported (picky :) ) nits fixed (Checked in)

Checking in mail_help.xhtml;
/cvsroot/mozilla/extensions/help/resources/locale/en-US/mail_help.xhtml,v  <-- 
mail_help.xhtml
new revision: 1.57; previous revision: 1.56
done

Comment 58

[Ian Neal]

Comment on attachment 176208 [details] [diff] [review]
As Stefan asked - using_priv_help to xhtml 1.1 (Checked in)

Checking in using_priv_help.xhtml;
/cvsroot/mozilla/extensions/help/resources/locale/en-US/using_priv_help.xhtml,v
 <--  using_priv_help.xhtml
new revision: 1.54; previous revision: 1.53
done

Comment 59

[Giacomo Magnini]

Leaving bug open for additional work (if any).

Comment 60

[Stefan [:stefanh]]

(In reply to comment #59)
> Leaving bug open for additional work (if any).
> 

cs_nav_prefs_appearance.xhtml needs some more work ;)

Comment 61

[Giacomo Magnini]

Attachment: cs_nav_prefs_appearance cleanup: a few divs, one line wrap and some empty lines removed. (Checked in)

Comment 62

[Ian Neal]

Comment on attachment 176850 [details] [diff] [review]
cs_nav_prefs_appearance cleanup: a few divs, one line wrap and some empty lines removed. (Checked in)

Checking in cs_nav_prefs_appearance.xhtml;
/cvsroot/mozilla/extensions/help/resources/locale/en-US/cs_nav_prefs_appearance
.xhtml,v  <--  cs_nav_prefs_appearance.xhtml
new revision: 1.27; previous revision: 1.26
done