282899 - Mailing List view does not show all cards

Status: RESOLVED FIXED

(MailNews Core :: Address Book, defect)

Description

[Jan Rieke]

User-Agent:       Mozilla/5.0 (Windows; U; Win98; de-DE; rv:1.7.5) Gecko/20041108 Firefox/1.0
Build Identifier: Thunderbird 1.0 (20041206)

When selecting a mailing list, it sometimes does not show all cards in the list,
a view of them are simply invisible. The properties dialog (double-click on list
on nav pane) still shows all contacts.

This bug is not really reproducable, it appears only sometimes.

In most cases there were invalid/empty entries in the list in the properties
dialog. When removing this invalid/empty entries manually, all cards are visible
in the list view correctly again.

Reproducible: Sometimes

Steps to Reproduce:
N/A
Actual Results:  
List view not showing all cards

Expected Results:  
List should show all cards

Comment 1

[Jan Rieke]

Bug appeared in connection with bug 282900, so there might be a connection.

Similar bugs: bug 272999, bug 152133, or maybe bug 276374.

Comment 2

[Jan Rieke]

The address book was originally imported from Outlook Express, but the import
corrupted the mailing lists, so they had to be restored manually.

Comment 3

[Gervase Markham [:gerv]]

This is an automated message, with ID "auto-resolve01".

This bug has had no comments for a long time. Statistically, we have found that
bug reports that have not been confirmed by a second user after three months are
highly unlikely to be the source of a fix to the code.

While your input is very important to us, our resources are limited and so we
are asking for your help in focussing our efforts. If you can still reproduce
this problem in the latest version of the product (see below for how to obtain a
copy) or, for feature requests, if it's not present in the latest version and
you still believe we should implement it, please visit the URL of this bug
(given at the top of this mail) and add a comment to that effect, giving more
reproduction information if you have it.

If it is not a problem any longer, you need take no action. If this bug is not
changed in any way in the next two weeks, it will be automatically resolved.
Thank you for your help in this matter.

The latest beta releases can be obtained from:
Firefox:     http://www.mozilla.org/projects/firefox/
Thunderbird: http://www.mozilla.org/products/thunderbird/releases/1.5beta1.html
Seamonkey:   http://www.mozilla.org/projects/seamonkey/

Comment 4

[sbadov]

i see the same or at least a simmilar bug in TB for windows, version 1.0.7 (also
older version 1.0.x) and TB 1.5 beta2.

the problem i see is that NOT ALL cards are shown in an "sub-list" althought
when i print this list or when i enter it in an compose email all the cards
(addresses) are there. it seems that with time less and less addresses are
visable. at the momenet i see 13 out of 31 addresses in the list.

Comment 5

[Mark Banner (:standard8)]

(In reply to comment #4)
> i see the same or at least a simmilar bug in TB for windows, version 1.0.7 
(also
> older version 1.0.x) and TB 1.5 beta2.
> the problem i see is that NOT ALL cards are shown in an "sub-list" althought
> when i print this list or when i enter it in an compose email all the cards
> (addresses) are there. it seems that with time less and less addresses are
> visable. at the momenet i see 13 out of 31 addresses in the list.

Can you recall if you have moved or delete cards that were contained with the 
list?

Comment 6

[Mark Ploch]

(In reply to comment #5)
> (In reply to comment #4)
> > i see the same or at least a simmilar bug in TB for windows, version 1.0.7 
> (also
> > older version 1.0.x) and TB 1.5 beta2.
> > the problem i see is that NOT ALL cards are shown in an "sub-list" althought
> > when i print this list or when i enter it in an compose email all the cards
> > (addresses) are there. it seems that with time less and less addresses are
> > visable. at the momenet i see 13 out of 31 addresses in the list.
> 
> Can you recall if you have moved or delete cards that were contained with the 
> list?
> 

I have  this exact problem myself.  If I create a list new by dragging cards
into the list all is fine.  However, if I go back later to add more cards the
new cards are not displayed.  You can verify they exist via properties.

Comment 7

[Wayne Mery (:wsmwk)]

(In reply to comment #6)
> I have  this exact problem myself.  If I create a list new by dragging cards
> into the list all is fine.  However, if I go back later to add more cards the
> new cards are not displayed.  You can verify they exist via properties.

Mark, please state your version (build string) when you report a problem. 

sbadov and Mark, in the future you probably want to add yourself as a cc in the bug so you are notified is someone wants to help you or ask you for more information.

Mark, are you on the lastest release? some mail list bugs have been fixed in the past year. 

sbadov and Mark, did you use import to get any of the addressed into your address book?

Comment 8

[sbadov]

> sbadov and Mark, did you use import to get any of the addressed into your
> address book?

no, i did not import any of this addresses.

i will attach an screenshot where the bug is  clearly seen. in the address book window we can see that only 13 addresses are listed, but this is not true. if we take a look at the properties we see that there are actually 31 addresses in that list. also when i send an emial all of the addresses are added to the "To:"

Comment 9

[sbadov]

Attachment: screenshot of this bug

Comment 10

[Mark Banner (:standard8)]

I can confirm this with an address book that I was sent. Now to try and find out why it happens...

Comment 11

[Mark Banner (:standard8)]

This problem is caused by a blank line in the mailing list - in the case I had I went to the extra blank line in the mailing list dialog and deleted it. Then I went to a different address book and back again (to refresh the view) and it was all fine. I think the root cause of this was fixed by bug 152133 but IMHO we should still cope with it.

Comment 12

[Mark Banner (:standard8)]

Attachment: Ensure we don't abort unnecessarily.

This problem comes down to the fact that the nsAddrDatabase code aborts if it finds a line in the mailing list where the currentRow is returned as null. The cause of that is a card that was in the mailing list has been deleted, but the reference hasn't been removed from the list. We fixed that back in bug 152133 however, there are will still be some address books around that have it, and IMHO we should cope with it anyway.

This fix "jumps" the currentRow in the mailing list (in HasMoreElements() ) if it is null and tries the next one instead. Protection is in there for the end of the list. Strictly speaking we shouldn't modify the state of the enumerator in HasMoreElements, but in this case it seems the most efficient way around the problem.

Comment 13

[David :Bienvenu]

Comment on attachment 207114 [details] [diff] [review]
Ensure we don't abort unnecessarily.

Whilst we have fixed
+  // that there are still

should be "...fixed that, there are still...

thx for the fix!

Comment 14

[[e-mail]]

Comment on attachment 207114 [details] [diff] [review]
Ensure we don't abort unnecessarily.

>+  while (mAddressPos + 1 <= mAddressTotal && !*aResult)
>+  {
>+    nsCOMPtr<nsIMdbRow> currentRow;
>+    nsresult rv = mDb->GetAddressRowByPos(mListRow, mAddressPos + 1,
>+                                          getter_AddRefs(currentRow));
>+    NS_ENSURE_SUCCESS(rv, rv);
> 
>+    *aResult = currentRow != nsnull;
> 
>+    if (!*aResult)
>+      ++mAddressPos;
>+  }
I don't like the way this loop is written; perhaps try this:
while (mAddressPos < mAddressTotal)
{
  /* fetch next row as above */

  if (currentRow) {
    *aResult = PR_TRUE;
    break;
  }

  ++mAddressPos;
}

Comment 15

[Mark Banner (:standard8)]

Attachment: Ensure we don't abort unnecessarily v2 (checked in to trunk).

Incorporated Neil's suggestion into the loop, carrying forward bienvenu's sr.

Comment 16

[Mark Banner (:standard8)]

Comment on attachment 207164 [details] [diff] [review]
Ensure we don't abort unnecessarily v2 (checked in to trunk).

Checked in to trunk:

/cvsroot/mozilla/mailnews/addrbook/src/nsAddrDatabase.cpp,v  <--  nsAddrDatabase.cpp
new revision: 1.140; previous revision: 1.139

Comment 17

[Mark Banner (:standard8)]

Comment on attachment 207164 [details] [diff] [review]
Ensure we don't abort unnecessarily v2 (checked in to trunk).

Requesting approval for 1.8.1 branch,

This fixes (Thunderbird & SeaMonkey) a problem whereby we don't always display all the email addresses that are in a mailing list.

Comment 18

[Mark Banner (:standard8)]

*** Bug 313796 has been marked as a duplicate of this bug. ***

Comment 19

[Mark Banner (:standard8)]

This was checked into trunk a while ago, therefore I'm marking as fixed. I'll check into branch if and when the patch eventually gets approval.

Comment 20

[Mark Banner (:standard8)]

Comment on attachment 207164 [details] [diff] [review]
Ensure we don't abort unnecessarily v2 (checked in to trunk).

Unfortunately, I forgot that this patch doesn't apply to the 1.8.1 branch as there were other significant changes that went in (bug 282899) that also affect the interface.

Therefore, we'd need to come up with a new patch to fix this for Thunderbird 2.0/SeaMonkey 1.5.