282917 - typo in nsHTTPCompressConv.cpp

Status: VERIFIED FIXED

(Core :: Networking, defect)

Description

[Esteve Sabate Juncosa]

User-Agent:       Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.7b) Gecko/20040421
Build Identifier: Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.7b) Gecko/20040421

Yesterdya i've downloaded the source tree for Mozilla and i was looking in the
source to find how the decompression of pages compressed at server works. In the
source i think that there is an error that makes compressed responses with
HTTP_COMPRESS_GZIP method never get decompressed. The involved file is
nsHTTPCompressConv.cpp and the involved line is line 99: in this line you make a
PL_strncasecmp(fromStr, HTTP_GZIP_TYPE, sieof(HTTP_COMPRESS_TYPE)) (Obviously,
the  pointer is rigth but not the length!!! so the comparation is always false).
I think that this is due a vi yy of the lineno 95. I hope that if this is true
help you to improve the excelent suite of software

Reproducible: Always

Comment 1

[Brendan Eich [:brendan]]

PL_strncasecmp's third argument is a maximum number of characters to compare,
but it will stop at the first NUL.

/be

Comment 2

[Hermann Schwab]

the code in branch, line 99:
http://lxr.mozilla.org/mozilla1.7/source/netwerk/streamconv/converters/nsHTTPCompressConv.cpp#86

in trunk:
http://lxr.mozilla.org/seamonkey/source/netwerk/streamconv/converters/nsHTTPCompressConv.cpp#99

Comment 3

[Christian :Biesinger (don't email me, ping me on IRC)]

while maybe not a bug, this is still a typo that confuses people who look at it.
it seems to me like we should still fix it.

Comment 4

[Christian :Biesinger (don't email me, ping me on IRC)]

Attachment: patch

Comment 5

[Brendan Eich [:brendan]]

Comment on attachment 174924 [details] [diff] [review]
patch

My apologies, thanks to biesi for reopening and sr=me FWIW.

/be

Comment 6

[Christian :Biesinger (don't email me, ping me on IRC)]

Checking in netwerk/streamconv/converters/nsHTTPCompressConv.cpp;
/cvsroot/mozilla/netwerk/streamconv/converters/nsHTTPCompressConv.cpp,v  <-- 
nsHTTPCompressConv.cpp
new revision: 1.24; previous revision: 1.23
done


Thank you for finding and reporting this typo!

Comment 7

[Worcester12345]

Though marked as fixed, this could use a better title. ;-)

Comment 8

[Stephen Donner [:stephend] Not actively reading bugmail]

Verified FIXED using LXR and Bonsai:

http://bonsai.mozilla.org/cvsview2.cgi?diff_mode=context&whitespace_mode=show&file=nsHTTPCompressConv.cpp&branch=&root=/cvsroot&subdir=mozilla/netwerk/streamconv/converters&command=DIFF_FRAMESET&rev1=1.23&rev2=1.24