Closed Bug 282983 Opened 19 years ago Closed 19 years ago

bug cloning doesn't work if classifications are enabled

Categories

(Bugzilla :: Creating/Changing Bugs, defect)

defect
Not set
normal

Tracking

()

RESOLVED FIXED
Bugzilla 2.20

People

(Reporter: glob, Assigned: shane.h.w.travis)

References

Details

Attachments

(1 file, 1 obsolete file)

bug cloning (bug 81642) doesn't work if classifications are enabled, you're
presented with the "select classification" page, and the cloned_bug_id isn't
passed on to the next stop of enter_bug.
Attached patch Code patch for tip (obsolete) — Splinter Review
Okay, I guess that doesn't surprise me; I know nothing about classifications,
and didn't have them enabled while writing this, so I didn't realize that there
were interactions.

The patch is a simple one, though; it makes the same change to
choose-classification as I had to make to choose-product. I have not actually
tried it, but logic tells me this is going to work. If someone who has a
classification-using BZ-tip installation could please let me know, I'd
appreciate it.
Attachment #175016 - Flags: review?
Comment on attachment 175016 [details] [diff] [review]
Code patch for tip

Actually, may as well request review from Byron; he noticed the omission, so
I'm betting he'll be able to tell if this fixes it. :)
Attachment #175016 - Flags: review? → review?(bugzilla)
Comment on attachment 175016 [details] [diff] [review]
Code patch for tip

sorry, this doesn't work. 

cloned_bug_id isn't passed to the choose-classification template, and you also
missed the link under 'showallproducts' in that template.
Attachment #175016 - Flags: review?(bugzilla) → review-
Fixed both things you mentioned. Again, not tested since I don't have the
ability; please let me know if this iteration works. Thank you very much!
Attachment #175016 - Attachment is obsolete: true
Attachment #175157 - Flags: review?(bugzilla)
Comment on attachment 175157 [details] [diff] [review]
Code patch for tip, take 2

r=glob
Attachment #175157 - Flags: review?(bugzilla) → review+
Flags: approval?
Flags: approval?
Flags: approval2.18+
Flags: approval+
Myk:

Bug Cloning (bug 86142) did not exist as part of 2.18, so approval2.18+ is 
meaningless in this situation. Please remove it at your earliest convenience.


Checking in enter_bug.cgi;
/cvsroot/mozilla/webtools/bugzilla/enter_bug.cgi,v  <--  enter_bug.cgi
new revision: 1.105; previous revision: 1.104
done
Checking in template/en/default/global/choose-classification.html.tmpl;
/cvsroot/mozilla/webtools/bugzilla/template/en/default/global/choose-
classification.html.tmpl,v  <--  choose-classification.html.tmpl
new revision: 1.3; previous revision: 1.2
done
Status: NEW → RESOLVED
Closed: 19 years ago
Resolution: --- → FIXED
Target Milestone: --- → Bugzilla 2.20
Depends on: 81642
*** Bug 285637 has been marked as a duplicate of this bug. ***
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: