282999 - remove Javascript LANGUAGE attribute in all files

Status: RESOLVED FIXED

(Bugzilla :: User Interface, defect)

Description

[Anne (:annevk)]

I started with this in earlier bugs and I think finishing it would be a good
thing. Especially to comply with HTML 4.01 Strict in the end.

For background information see bug 280410, bug 249875 and bug 280093.

Comment 1

[Anne (:annevk)]

Attachment: patch #1

Comment 2

[Anne (:annevk)]

See also:
 <http://lxr.mozilla.org/bugzilla/search?string=language%3D>

Comment 3

[Frédéric Buclin]

Comment on attachment 174994 [details] [diff] [review]
patch #1

Two files have a <script type="application/x-javascript"
language="JavaScript">:

./template/en/default/attachment/diff-file.html.tmpl
./template/en/default/attachment/edit.html.tmpl

They are not included in your patch. Shouldn't they?

Else, it looks good to me. r=LpSolit, but holding approval till we discuss this
point, as well as if type="application/x-javascript" should be replaced by
type="text/javascript".

Comment 4

[Anne (:annevk)]

Attachment: patch #2 - addressing comment 3

This fixes the files mentioned in comment 3 and help-header.html.tmpl. IE does
not support 'application/x-javascript' so it is better to use
'text/javascript'. (That is for HTML files, by the way. For XML it does not
really matter (IE does not support those) and server side should always be
'application/x-javascript'.)

Comment 5

[Frédéric Buclin]

Comment on attachment 175033 [details] [diff] [review]
patch #2 - addressing comment 3

r=LpSolit

Now please merge these two patches into a single one. The patch will be then
ready for approval.

Comment 6

[Anne (:annevk)]

Attachment: patch #3 - combines #1 and #2

Comment 7

[Kevin Benton]

Quick change to prevent (my) confusion :)

Comment 8

[Joel Peshkin]

Checked in for Anne

Checking in template/en/default/admin/flag-type/list.html.tmpl;
/cvsroot/mozilla/webtools/bugzilla/template/en/default/admin/flag-type/list.html.tmpl,v
 <--  list.html.tmpl
new revision: 1.10; previous revision: 1.9
done
Checking in template/en/default/attachment/diff-file.html.tmpl;
/cvsroot/mozilla/webtools/bugzilla/template/en/default/attachment/diff-file.html.tmpl,v
 <--  diff-file.html.tmpl
new revision: 1.5; previous revision: 1.4
done
Checking in template/en/default/attachment/diff-header.html.tmpl;
/cvsroot/mozilla/webtools/bugzilla/template/en/default/attachment/diff-header.html.tmpl,v
 <--  diff-header.html.tmpl
new revision: 1.8; previous revision: 1.7
done
Checking in template/en/default/attachment/edit.html.tmpl;
/cvsroot/mozilla/webtools/bugzilla/template/en/default/attachment/edit.html.tmpl,v
 <--  edit.html.tmpl
new revision: 1.27; previous revision: 1.26
done
Checking in template/en/default/bug/comments.html.tmpl;
/cvsroot/mozilla/webtools/bugzilla/template/en/default/bug/comments.html.tmpl,v
 <--  comments.html.tmpl
new revision: 1.15; previous revision: 1.14
done
Checking in template/en/default/bug/dependency-tree.html.tmpl;
/cvsroot/mozilla/webtools/bugzilla/template/en/default/bug/dependency-tree.html.tmpl,v
 <--  dependency-tree.html.tmpl
new revision: 1.14; previous revision: 1.13
done
Checking in template/en/default/bug/edit.html.tmpl;
/cvsroot/mozilla/webtools/bugzilla/template/en/default/bug/edit.html.tmpl,v  <--
 edit.html.tmpl
new revision: 1.56; previous revision: 1.55
done
Checking in template/en/default/bug/create/create-guided.html.tmpl;
/cvsroot/mozilla/webtools/bugzilla/template/en/default/bug/create/create-guided.html.tmpl,v
 <--  create-guided.html.tmpl
new revision: 1.23; previous revision: 1.22
done
Checking in template/en/default/bug/create/create.html.tmpl;
/cvsroot/mozilla/webtools/bugzilla/template/en/default/bug/create/create.html.tmpl,v
 <--  create.html.tmpl
new revision: 1.45; previous revision: 1.44
done
Checking in template/en/default/global/header.html.tmpl;
/cvsroot/mozilla/webtools/bugzilla/template/en/default/global/header.html.tmpl,v
 <--  header.html.tmpl
new revision: 1.37; previous revision: 1.36
done
Checking in template/en/default/global/help-header.html.tmpl;
/cvsroot/mozilla/webtools/bugzilla/template/en/default/global/help-header.html.tmpl,v
 <--  help-header.html.tmpl
new revision: 1.4; previous revision: 1.3
done
Checking in template/en/default/list/quips.html.tmpl;
/cvsroot/mozilla/webtools/bugzilla/template/en/default/list/quips.html.tmpl,v 
<--  quips.html.tmpl
new revision: 1.13; previous revision: 1.12
done
Checking in template/en/default/reports/create-chart.html.tmpl;
/cvsroot/mozilla/webtools/bugzilla/template/en/default/reports/create-chart.html.tmpl,v
 <--  create-chart.html.tmpl
new revision: 1.11; previous revision: 1.10
done
Checking in template/en/default/search/form.html.tmpl;
/cvsroot/mozilla/webtools/bugzilla/template/en/default/search/form.html.tmpl,v 
<--  form.html.tmpl
new revision: 1.30; previous revision: 1.29
done
Checking in template/en/default/search/search-create-series.html.tmpl;
/cvsroot/mozilla/webtools/bugzilla/template/en/default/search/search-create-series.html.tmpl,v
 <--  search-create-series.html.tmpl
new revision: 1.10; previous revision: 1.9
done
Checking in template/en/default/search/search-specific.html.tmpl;
/cvsroot/mozilla/webtools/bugzilla/template/en/default/search/search-specific.html.tmpl,v
 <--  search-specific.html.tmpl
new revision: 1.11; previous revision: 1.10
done