Closed
Bug 283049
Opened 20 years ago
Closed 20 years ago
nsISocketTransportService cleanup
Categories
(Core :: Networking, defect, P2)
Core
Networking
Tracking
()
RESOLVED
FIXED
mozilla1.8beta2
People
(Reporter: darin.moz, Assigned: darin.moz)
References
Details
(Keywords: arch)
Attachments
(1 file)
|
13.76 KB,
patch
|
Biesinger
:
review+
bzbarsky
:
superreview+
asa
:
approval1.8b2+
|
Details | Diff | Splinter Review |
nsISocketTransportService cleanup
we should move init, shutdown, and autodialEnabled to some private interface
since those are implementation details.
|
Assignee | |
Updated•20 years ago
|
Status: NEW → ASSIGNED
Target Milestone: --- → mozilla1.8beta2
|
|
Assignee | |
Updated•20 years ago
|
Priority: -- → P2
|
|
Assignee | |
Comment 1•20 years ago
|
||
Attachment #179994 -
Flags: review?(cbiesinger)
|
||
Comment 2•20 years ago
|
||
Comment on attachment 179994 [details] [diff] [review]
v1 patch
looks great
Attachment #179994 -
Flags: review?(cbiesinger) → review+
|
|
Assignee | |
Updated•20 years ago
|
Attachment #179994 -
Flags: superreview?(bzbarsky)
|
||
Updated•20 years ago
|
Attachment #179994 -
Flags: superreview?(bzbarsky) → superreview+
|
|
Assignee | |
Comment 3•20 years ago
|
||
Comment on attachment 179994 [details] [diff] [review]
v1 patch
being an API change, i'd really like to see this patch in for the firefox 1.1
DPR
Attachment #179994 -
Flags: approval1.8b2?
|
||
Comment 4•20 years ago
|
||
Comment on attachment 179994 [details] [diff] [review]
v1 patch
a=asa
Attachment #179994 -
Flags: approval1.8b2? → approval1.8b2+
|
|
Assignee | |
Comment 5•20 years ago
|
||
fixed-on-trunk
Status: ASSIGNED → RESOLVED
Closed: 20 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•