Closed Bug 283131 Opened 20 years ago Closed 20 years ago

Leaking fd/registry in OOM cases

Categories

(Core :: XPCOM, defect)

defect
Not set
normal

Tracking

()

RESOLVED FIXED

People

(Reporter: timeless, Assigned: timeless)

References

()

Details

Attachments

(1 obsolete file)

this is an audit.
Attachment #175137 - Flags: review?(dougt)
Comment on attachment 175137 [details] [diff] [review]
handle leaks as well as arena allocation failure

I don't understand why the last two changes in this file were made.  Why don't
you test for a bad nsFactoryEntry allocation?
(In reply to comment #2)
> I don't understand why the last two changes in this file were made.  Why don't
> you test for a bad nsFactoryEntry allocation?

The void* placement new in the standard C++ library (18.4.1.3 in ISO/IEC
14882:1998) *always* returns its argument.  It's the identity function.  And
there's already a null-check before the call to placement new, as it should be.
Attachment #175137 - Flags: review?(dougt) → review+
Comment on attachment 175137 [details] [diff] [review]
handle leaks as well as arena allocation failure

mozilla/xpcom/components/nsComponentManager.cpp 	1.262
Attachment #175137 - Attachment is obsolete: true
Status: NEW → RESOLVED
Closed: 20 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: