28314 - New card should have setting "Send email as plain text" turn on by default

Status: VERIFIED FIXED

(MailNews Core :: Composition, defect, P3)

Description

[Jean-Francois Ducarroz]

When you send an HTML message for the first time to a recipient which has no 
entry in any of the AB, the message compose window will ask you if you want to 
send this message in plain text mode (see bug 17072). However, the next time to 
send an HTML message to the same user, it will be sent in HTML format without 
asking you anything because the recipient will have this time a card in the 
collected addresses book. This because, by default, when a new card is created, 
the setting "Send email as plain text" is off.

We must set this setting to on. Else we wont be a friendly email client & the 
HTML intelligent feature will never works correclty

Comment 1

[Akkana Peck]

Another way of saying this: we shouldn't send html to someone unless the user
says it's okay.  The way the current history ab is set up, the user has no
chance to answer this question, and ends up wondering why we're always ignoring
his "Ask me if the message contains formatting" preference.

Comment 2

[fenella]

Assign it to me since it is the intelligent send issue.

Comment 3

[hangas]

JF, good bug.  After talking to jglick, mscott, and bienvenu the solution seems 
to be that the intelligent send feature should pass the value for this checkbox 
in the card.  The api for the collected address book feature should be expanded 
to allow for this parameter.  Sending the bug back to you...  :-)

Comment 4

[leger]

Putting on PDT+ radar for beta1.

Comment 5

[Jean-Francois Ducarroz]

After meeting with Sol & Phil, we have decided to not do anything complexe for B1. We will only reverse the default 

value of the checkbox "Send email as plain text (no HTML)" to true for all new card (collected or not), like it was in 

4.x.



Here is the diffs:



Index: nsAbCardProperty.cpp

===================================================================

RCS file: /cvsroot/mozilla/mailnews/addrbook/src/nsAbCardProperty.cpp,v

retrieving revision 1.23

diff -r1.23 nsAbCardProperty.cpp

134c134

< 	m_bSendPlainText = PR_FALSE;

---

> 	m_bSendPlainText = PR_TRUE;



Index: abCardOverlay.js

===================================================================

RCS file: /cvsroot/mozilla/mailnews/addrbook/resources/content/abCardOverlay.js,v

retrieving revision 1.13

diff -r1.13 abCardOverlay.js

32c32,35

< 	editCard.card = 0;

---

> 	var cardproperty = Components.classes["component://netscape/addressbook/cardproperty"].createInstance();

> 	cardproperty = cardproperty.QueryInterface(Components.interfaces.nsIAbCard);

> 

> 	editCard.card = cardproperty;

51a55,56

> 	GetCardValues(editCard.card, document);

> 

153,156c158

< 		var cardproperty = Components.classes["component://netscape/addressbook/

cardproperty"].createInstance();

< 		cardproperty = cardproperty.QueryInterface(Components.interfaces.nsIAbCard);

< 

< 		if ( cardproperty )

---

> 		if ( editCard.card )

158c160

< 			SetCardValues(cardproperty, document);

---

> 			SetCardValues(editCard.card, document);

160c162

< 			cardproperty.addCardToDatabase(uri);

---

> 			editCard.card.addCardToDatabase(uri);

Comment 6

[Jean-Francois Ducarroz]

Fixed and checked in

Comment 7

[fenella]

Linux (2000-02-23-08 M14)
Win32 (2000-02-23-09 M14)
Mac (2000-02-23-12 M14)
This works on all 3 platforms..
New card has setting "Send email as plain text" turn on by default.