283149 - Move from nsIScriptGlobalObject to nsIDocShell for disabling JS

Status: RESOLVED FIXED

(Core :: DOM: Editor, defect)

Description

[timeless]

It doesn't seem like we really need any of the magic that nsIScriptGlobalObject
provides, and if i can get editor to not use it, i think that would be a good
thing. there are two uses of sgo in editing session, the other is to get a non
refcounted pointer for GetDocShellFromWindow.

Comment 1

[timeless]

Attachment: use the docshell to disable scripts along with all the other children

Comment 2

[Kathleen :Brade]

Comment on attachment 175138 [details] [diff] [review]
use the docshell to disable scripts along with all the other children

I actually do approve of this but I'm marking it as r- because jst has a large
patch which includes some changes to the scripting flag (so it can be restored
to previous setting).  If jst wants to incorporate this tiny patch into his
patch, that is fine.

jst--when are you going to land?

Comment 3

[Johnny Stenback (:jst)]

Comment on attachment 175138 [details] [diff] [review]
use the docshell to disable scripts along with all the other children

My changes landed, this'll need to be updated before reviewing...

Comment 4

[timeless]

Attachment: second pass, recovered from jst's changes, almost killing presshell

Comment 5

[Johnny Stenback (:jst)]

Comment on attachment 175462 [details] [diff] [review]
second pass, recovered from jst's changes, almost killing presshell

sr=jst

Comment 6

[Stephen Donner [:stephend] Not actively reading bugmail]

A bug that has a patch landed shouldn't really be in the UNCONFIRMED state. 
Bumping to NEW.

Comment 7

[timeless]

Comment on attachment 175462 [details] [diff] [review]
second pass, recovered from jst's changes, almost killing presshell

mozilla/editor/composer/src/nsEditingSession.cpp	1.35