283156 - make-makefile doesn't like DIRS = ../somewhere-else

Status: RESOLVED FIXED

(Firefox Build System :: General, defect)

Description

[Benjamin Smedberg]

If you have DIRS = ../somewhere-else, and you remove ../somewhere-else/Makefile,
make-makefiles is supposed to recreate it, but make-makefiles was never taught
about upwards-reaching paths, so it assumes all path-parts are downwards, and
tries to access

$(DEPTH)/../../../somewhere-else
instead of 
$(DEPTH)/../somewhere-else

Comment 1

[Mike Shaver (:shaver emeritus)]

I'm not able to reproduce this on Linux, though Silver was able to on Windows. 
Silver: can you remind me of your specific perl configuration?

Comment 2

[James Ross]

Win 2K, MSVC 13.10 (.NET 2003 Toolkit?), ActiveState Perl 5.8.3 IIRC (I'm not at
my box currently). At least I think it was using AS Perl here... I do have
Cygwin's as well.

If you want me to try a debug run of make in this situation (or any other
commands), I can do so when I get back home on Friday (maybe before if I'm
lucky).

Comment 3

[Mike Shaver (:shaver emeritus)]

Yeah, can you uncomment the |$debug = 1| line in make-makefile, delete
db/sqlite3/src/Makefile, and build in storage/ with the patch from 283057?  I am
not able to reproduce this myself, but my windows environment is not something
I'm tremendously capable in.

Comment 4

[James Ross]

I got the same as with the debug commented out when building (it is make that
can't find the file).

For completeness:

M:\tree-main\objdir\storage>make
/usr/bin/make export
make[1]: Entering directory `/cygdrive/m/tree-main/objdir/storage'
make[2]: Entering directory `/cygdrive/m/tree-main/objdir/db/sqlite3/src'
Makefile:93: ../../../../../../../source-HEAD/mozilla/config/rules.mk: No such
file or directory
make[2]: *** No rule to make target
`../../../../../../../source-HEAD/mozilla/config/rules.mk'.  Stop.
make[2]: Leaving directory `/cygdrive/m/tree-main/objdir/db/sqlite3/src'
make[1]: *** [export] Error 2
make[1]: Leaving directory `/cygdrive/m/tree-main/objdir/storage'
make: *** [all] Error 2

Hmm. This time I got something (no idea what I changed to make it do this):

M:\tree-main\objdir\storage>make -sw
make: Entering directory `/cygdrive/m/tree-main/objdir/storage'
make[1]: Entering directory `/cygdrive/m/tree-main/objdir/storage'
ac_given_srcdir = ../../../source-HEAD/mozilla
depth           = ..
ac_given_srcdir = ../../source-HEAD/mozilla
ac_given_srcdir = ../../../source-HEAD/mozilla
depth           = ..
ac_given_srcdir = ../../source-HEAD/mozilla
object_fullpath = /cygdrive/m/tree-main/objdir/storage
object_root     = /cygdrive/m/tree-main/objdir
source_subdir   = storage/
makefiles       = storage/../db/sqlite3/src/Makefile
given_srcdir    = ../../source-HEAD/mozilla
ac_dir     = storage/../db/sqlite3/src
ac_file    = storage/../db/sqlite3/src/Makefile
ac_file_in = ../../source-HEAD/mozilla/storage/../db/sqlite3/src/Makefile.in
srcdir     = ../../../../../../../source-HEAD/mozilla/storage/../db/sqlite3/src
top_srcdir = ../../../../../../../source-HEAD/mozilla
cwd        = /cygdrive/m/tree-main/objdir

creating storage/../db/sqlite3/src/Makefile

Comment 5

[James Ross]

Attachment: Remove upward pointing directory elements

Comment 6

[James Ross]

The r+ is from shaver on IRC, for reference.

Comment 7

[James Ross]

Checked in --> FIXED.

Comment 8

[Mike Shaver (:shaver emeritus)]

Alas, that doesn't work for all cases (such as those in which ../configure is
invoked, instead of /abspath/to/configure or relpath/to/configure).  I have
something that does, though!  Coming up.

Comment 9

[Mike Shaver (:shaver emeritus)]

Attachment: Remove both .. and the matching "forward" path components.

Much better, says my test-builder.

Comment 10

[Benjamin Smedberg]

Comment on attachment 176187 [details] [diff] [review]
Remove both .. and the matching "forward" path components.

Sure. Make sure you don't check in the $debug = 1 change

Comment 11

[Mike Shaver (:shaver emeritus)]

Encore avec du FIXED.