Closed
Bug 283183
Opened 21 years ago
Closed 21 years ago
check_multi in Config.pm returns a bad error message if the check fails
Categories
(Bugzilla :: Administration, task)
Tracking
()
RESOLVED
FIXED
Bugzilla 2.20
People
(Reporter: LpSolit, Assigned: LpSolit)
Details
Attachments
(1 file)
|
1.04 KB,
patch
|
mkanat
:
review+
|
Details | Diff | Splinter Review |
return "Invalid choice '$value' for single-select list param '$param'";
should be
return "Invalid choice '$value' for single-select list param '$param->{'name'}'";
Same remark about
return "Invalid choice '$chkParam' for multi-select list param '$param'";
Waiting for wurblzap's patch in bug 283019 to land before submitting my patch to
avoid bitrot.
|
Assignee | |
Updated•21 years ago
|
Status: NEW → ASSIGNED
Target Milestone: --- → Bugzilla 2.20
|
|
Assignee | |
Comment 1•21 years ago
|
||
Replace $param by $param->{'name'}.
Attachment #175835 -
Flags: review?
|
|
||
Comment 2•21 years ago
|
||
Comment on attachment 175835 [details] [diff] [review]
patch, v1
Yeah, that looks obviously correct on inspection.
Attachment #175835 -
Flags: review? → review+
|
|
||
Updated•21 years ago
|
Flags: approval?
|
||
Updated•21 years ago
|
Flags: approval? → approval+
|
|
||
Comment 3•21 years ago
|
||
Checking in Bugzilla/Config.pm;
/cvsroot/mozilla/webtools/bugzilla/Bugzilla/Config.pm,v <-- Config.pm
new revision: 1.35; previous revision: 1.34
done
Status: ASSIGNED → RESOLVED
Closed: 21 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•