Closed Bug 283230 Opened 20 years ago Closed 20 years ago

POD for Bugzilla::Flag

Categories

(Bugzilla :: Documentation, enhancement)

Product:
Bugzilla
Component:
Documentation
Version:
2.19.2
Type:
enhancement
Priority:
Not set
Severity:
normal

Tracking

()

Status:
RESOLVED FIXED
Milestone:
Bugzilla 2.20

People

(Reporter: kbenton, Assigned: kbenton)

Details

Attachments

(1 file, 2 obsolete files)

Update to fix bitrot
11.88 KB, patch
mkanat
: review+
Details | Diff | Splinter Review 
POD for Bugzilla::Flag
OS: Windows XP → All
Hardware: PC → All
Attached patch POD for Bugzilla::Flag (obsolete) — — Splinter Review 

        Attachment #175224 -
        Flags: review?(documentation)

    
    

    
  

      
      
      
      

        Attached patch
          
          
        Changes as requested by Max (obsolete)
        — 
          — Splinter Review
      

    


  
Assignee: documentation → kevin.benton

        Attachment #175224 -
        Attachment is obsolete: true
Status: NEW → ASSIGNED

        Attachment #175355 -
        Flags: review?(documentation)

    
  

        Attachment #175224 -
        Flags: review?(documentation)

    
    

    
  
Comment on attachment 175355 [details] [diff] [review]
Changes as requested by Max

Looks good! Two comments:

1) I think it's "begin undocumented" not "begin private".

2) Add an XXX wherever it says "Somebody please document this."

        Attachment #175355 -
        Flags: review?(documentation) → review+

    
  
Severity: normal → enhancement
Flags: approval?
Target Milestone: --- → Bugzilla 2.20
Version: 2.19.1 → 2.19.2
Flags: approval? → approval+

    
    

    
  
Also a small bit of bitrot on this one.

    
    

    
  
Some small bitrot here preventing checkin.

Hunk #8 FAILED at 460.


    
    

    
  


  
Re-applied same patch against updated code.

        Attachment #175355 -
        Attachment is obsolete: true

        Attachment #177506 -
        Flags: review?

    
  

        Attachment #177506 -
        Flags: review? → review?(documentation)

    
  

        Attachment #177506 -
        Flags: review?(documentation) → review?(mkanat)

    
    

    
  
Comment on attachment 177506 [details] [diff] [review]
Update to fix bitrot

OK, I trust you. :-)

        Attachment #177506 -
        Flags: review?(mkanat) → review+

    
    

    
  
There was some bitrot, but I felt comfortable fixing it on checkin. Basically,
the prototype for Flag::process had changed. It was an easy, simple fix, just
removed a line or two from the docs.

Checking in Bugzilla/Flag.pm;
/cvsroot/mozilla/webtools/bugzilla/Bugzilla/Flag.pm,v  <--  Flag.pm
new revision: 1.33; previous revision: 1.32
done

Status: ASSIGNED → RESOLVED
Closed: 20 years ago
Resolution: --- → FIXED

          You need to log in
          before you can comment on or make changes to this bug.
        






  

    
  







  

    

      
Attachment

      

      
      
      
      
    

    

      

        

          

            
General

            

              Creator: 



            

            
Created: 

            
Updated: 

            
Size: