283240 - xf:message with @level=modal not centered

Status: RESOLVED FIXED

(Core Graveyard :: XForms, defect)

Description

[aaronr]

Other implementations display their modal xf:message windows centered either on
the desktop or on the browser window.  We show ours in the upper left corner of
the browser window (coordinate 0,0 I'm guessing).

I would suggest that we show the popup centered to the desktop.  Because if the
center of the browser is offscreen, that makes it very difficult to dismiss the
popup.  fP has that problem.

Does this happen cross platform?  Definitely happens on Windows XP.

Comment 1

[aaronr]

Attachment: testcase that shows the problem

click on the trigger.  It will popup a xf:message on the DOMActivate event.

Comment 2

[Doron Rosenberg (IBM)]

You probably want to do something like this:

http://lxr.mozilla.org/seamonkey/source/xpinstall/src/nsXPInstallManager.cpp#365

Comment 3

[Olli Pettay [:smaug][[e-mail]] (holiday -> Aug30)]

I don't see this on Linux.
Does this happen only with level="modal" or also with
level="modeless"?

Comment 4

[aaronr]

also happens with 'modeless'

Comment 5

[aaronr]

Attachment: proposed fix

added (at smaug's suggestion) 'centerscreen' to get modal and modeless message
windows to open centered on the browser window

Comment 6

[aaronr]

Doron, could you review and checkin for me?

Comment 7

[Doron Rosenberg (IBM)]

r=me and checked in.