283274 - Can't go back if forgot to accept license agreement for plugin

Status: VERIFIED FIXED

(Toolkit Graveyard :: Plugin Finder Service, enhancement)

Description

[u88484]

When attempting to install the flash player, if you do not accept the license
there is no way to go back to accept it if you accidently clicked next and
bypassed accepting the license. You then have to click finish and click the
'Install Missing Plugin' button again.

Steps to reproduce:
1) Go to a page that requires flash
2) Click the 'Install Missing Plugin' button
3) Make sure 'Macromedia Flash Player' is checked
4) Click 'next' button
5) Leave default of 'do not accept (plugin will not be installed)' checked
6) No back button incase you didnt mean to click next before accepting

Also reproduciable with other plugins

Expected results: Be able to click the 'Back' button to then click to accept the
license agreemnet.

Comment 1

[Doron Rosenberg (IBM)]

This is by design, so an enhancment request.

Comment 2

[Doron Rosenberg (IBM)]

The fix is to not enable the next button if only one plugin/license exists

Comment 3

[Doron Rosenberg (IBM)]

Attachment: le patch

Only do this if one plugin will be installed.  We could decide to simply require all plugin licenses to be accepted before we start installation and make a previous button work.

Comment 4

[Doron Rosenberg (IBM)]

checked into trunk

Comment 5

[Doron Rosenberg (IBM)]

Comment on attachment 203424 [details] [diff] [review]
le patch

ff2.0 candidate

Comment 6

[Doron Rosenberg (IBM)]

Note that this bug caused a regression (322833), which has a patch too.

Comment 7

[Benjamin Smedberg]

Comment on attachment 203424 [details] [diff] [review]
le patch

Please request branch-1.8.1 from mconnor when the regression is fixed.

Comment 8

[:Gavin Sharp [email: [e-mail]]]

The patch from this bug was included in the patch for bug 264282, and it was landed on the 1.8 branch.

Comment 9

[:Gavin Sharp [email: [e-mail]]]

(and caused bug 322833 there)