283275 - Plugin finder service showing wrong plugins needed for a page after a tab closed that plugin service was ran

Status: RESOLVED FIXED

(Toolkit Graveyard :: Plugin Finder Service, defect)

Description

[u88484]

Steps to reproduce:
1) Open a page with that requires flash (without having the flash player plugin
installed) http://www.homestarrunner.com/main2.html
2) Start the process to install the plugin. Notice that only flash is required
for that page. Do not close tab
3) Next open in a new tab http://www.macromedia.com/shockwave/welcome/
4) Start the process to install the plugins. Notice that both flash and
shockwave are required for that page.
5) Close the tab for http://www.macromedia.com/shockwave/welcome/
6) Now go back to the tab with http://www.homestarrunner.com/main2.html and
start to install the plugin and for some reason both shockwave and flash show
that they are required for that page when only flash is required.

Expected results: 
Only flash should be shown to be needed since the other tab was closed. So some
kind of cache is not being cleared when the tab from macromedia is closed.

Please change the summay if need be becuase I really couldn't thing of a great
summary for this bug

Comment 1

[u88484]

Please start the process to install the plugin via the Information bar

Comment 2

[Doron Rosenberg (IBM)]

What version of Firefox are you using?  I can't reproduce it on the latest trunk
CVS on Windows XP.

Comment 3

[Doron Rosenberg (IBM)]

Attachment: le patch

Comment 4

[u88484]

Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.8b2) Gecko/20050222
Firefox/1.0+

Comment 5

[Doron Rosenberg (IBM)]

Comment on attachment 175316 [details] [diff] [review]
le patch

pathc for different bug, sorry.

Comment 6

[Doron Rosenberg (IBM)]

Can't reproduce on CVS pull from 30 mins ago on WinXP.  We have a cache per tab,
so this should never happen.

Comment 7

[u88484]

weird, even happens with the latest beast-trunk build with fresh clean profile
(20050223 21:48 build)

Comment 8

[Jennifer Sherie Case]

Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.7.6) Gecko/20050223
Firefox/1.0.1

Well I wnt to a site with todays build and I had it installed previously, but
then it asked for it to be installed on this build. It works fine for me.

Comment 9

[Doron Rosenberg (IBM)]

(In reply to comment #7)
> weird, even happens with the latest beast-trunk build with fresh clean profile
> (20050223 21:48 build)

Maybe you have an extension installed for tabbrowsing?

Comment 10

[u88484]

Attachment: wrong plugin detected

This is with clean profile and fresh install(zip) no extensions. Only thing not
default is way I way the toolbar setup and removed the lines between the
toolbars...but even with that default, same thing.

I'll try explaining the steps again in a few minutes

Comment 11

[u88484]

Re-explaining in more detail:
1) Go to http://www.homestarrunner.com/main2.html
2) Click on the 'Install Missing plugins' button on the information bar
3) Notice flash is required for that page and click the 'Cancel' button
4) Leave tab open and do not refresh it
5) hit ctrl+t to open a new tab, paste in
http://www.apple.com/trailers/fox/becauseofwinndixie/large.htm and hit enter to
load the page
6) Click on the 'Install Missing plugins' button on the information bar
7) Notice that quicktime is needed for that page and hit 'Cancel' button and
close tab
8) Click on the tab to go back to the first link, do not refresh the page or you
won't be able to reproduce
9) Click on the 'Install Missing plugins' button on the information bar
10) Quicktime is still showing as needed on that page

Comment 12

[Doron Rosenberg (IBM)]

still can't reproduce.

Comment 13

[Teune van Steeg]

Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.8b2) Gecko/20050224
Firefox/1.0+
WinXP, fresh profile, nightly zip build

Can confirm this with the links in comment #1 and steps in comment #11.
Resulting in asking to install both shockwave and flash where only flash is
required. 
(Apparently the zip build finds the quicktime plugin installed on my computer,
so I can't test with the quicktime link in comment #11)

Comment 14

[Teune van Steeg]

In the Firefox 1.0.1 test build, and Firefox 1.0 the plugin notification bar
just disappears if you click cancel in step 3 in comment #11. So you'll have to
refresh the tab to bring the notification bar up again: no chance to reproduce
on the branch.

Comment 15

[Doron Rosenberg (IBM)]

Interesting - my cvs builds (debug) don't show this behavior, but the nightly
shows it.  Funky indeed.

Comment 16

[Doron Rosenberg (IBM)]

targetting 1.1

Comment 17

[Doron Rosenberg (IBM)]

Attachment: store missing plugins on the tab itself and not in an hash

The problem here was that for object hashes, the DOMNode (the tab) gets
serialized to string, so each tab gets the same key.  Solution: store the
missing plugins in an array directly on the tab.

Comment 18

[Mike Connor [:mconnor]]

Comment on attachment 175586 [details] [diff] [review]
store missing plugins on the tab itself and not in an hash

sorry about the latency here!

Comment 19

[Mike Kaply [:mkaply]]

Comment on attachment 175586 [details] [diff] [review]
store missing plugins on the tab itself and not in an hash

a=mkaply

Comment 20

[Doron Rosenberg (IBM)]

checked in, thanks for review.