283277 - "Firefox needs to be restarted for the plugin(s) to work.'' should not be shown if the plugins requiring restart were not installed.

Status: RESOLVED FIXED

(Toolkit Graveyard :: Plugin Finder Service, defect)

Description

[u88484]

Steps to reproduce:
1) http://www.macromedia.com/shockwave/welcome/
2) Start to isntall plugins via the information bar
3) Uncheck shockwave while leaving flash checked (vice versa)
4) Click next and leave 'do not accept license (do not install plugin) selected
5) click next and the plugin service tells you 'Firefox finished installing the
missing plugins..Macromedia Flash...License not accepted...Firefox needs to be
restarted for the plugin(s) to work.'

No plugin was installed so this message shouldnt be present.  

Two problems: 
Message should be 'Plugin(s) not installed' list plugin and explanion why
(license not accepted) 

Should not say firefox needs to be restarted for the plugin to work

Comment 1

[u88484]

Also just noticed that from above url if you try installing shockwave by itself
via the puzzle piece icon placehold and do not accept that the same wrong
message shows but with flash the same message except 'Firefox needs to be
restarted for the plugin(s) to work' is not present 

Comment 2

[Doron Rosenberg (IBM)]

THe bug here is that "Firefox needs to be restarted for the plugin(s) to work.'"
should not be shown if the plugins requiring restart were not installed.

Comment 3

[Doron Rosenberg (IBM)]

Probably could add a message if no plugins were installed.

Comment 4

[Doron Rosenberg (IBM)]

Attachment: le patch

Comment 5

[Mike Kaply [:mkaply]]

Comment on attachment 175320 [details] [diff] [review]
le patch

r=mkaply - don't checkin the whitespace change at the end

Comment 6

[Doron Rosenberg (IBM)]

checked in.