283292 - Code preventing more than 8 compose windows broken

Status: RESOLVED INVALID

(Thunderbird :: Message Compose Window, defect)

Description

[Martin]

User-Agent:       Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.7.5) Gecko/20041107 Firefox/1.0
Build Identifier: version 1.0 (20041206)

I just browsed through the file mailCommands.js. In line 266, the comment reads
that this could would prevent more than eight compose windows. I did not dive
into it, but with my Thunderbird 1.0, pressing Ctrl-M ten times, it opens ten
compose windows. 

I am not sure, why we need to limit the number of compose windows at all...
Maybe instead of fixing the code, we could just get rid of it ;)

http://lxr.mozilla.org/mailnews/source/mail/base/content/mailCommands.js#266

Reproducible: Always

Steps to Reproduce:
1. open Thunderbird
2. press Ctrl-M 10 times ;)

Actual Results:  
10 compose windows opened

Expected Results:  
The comment in the code at least, says no more than 8 compose windows should open.

Comment 1

[Tuukka Tolvanen (sp3000)]

that's intended to prevent opening an unreasonable amount of compose windows
/with one command/, say, by selecting all in a folder and hitting Reply. seems
to be working, too (although a confirmation dialog, or message stating that the
number of windows opened was limited, would be nice)

Comment 2

[Tuukka Tolvanen (sp3000)]

can't blame anyone for getting lost in the atrociously random indenting over
there, though. *shudder*