283317 - xpical.dll should not be built on trunk in xpi builds

Status: RESOLVED WORKSFORME

(Calendar :: Sunbird Only, defect)

Description

[Andy Willis (abwillis)]

With the changes in calendar the xpi builds should not create an xpical.dll. 
The makefile.in still tries to build the xpical.dll which causes a failure when
building the xpi.

Comment 1

[Peter Weilbacher]

If I patch it with this

RCS file: /cvsroot/mozilla/calendar/Makefile.in,v
retrieving revision 1.19
diff -u -r1.19 Makefile.in
--- calendar/Makefile.in        7 Jan 2005 19:16:45 -0000       1.19
+++ calendar/Makefile.in        5 Mar 2005 15:33:03 -0000
@@ -110,8 +110,8 @@
        mkdir -p ./xpi/chrome
        mkdir -p ./xpi/other_stuff
        cp $(DEPTH)/dist/bin/chrome/calendar.jar ./xpi/chrome
-       cp libxpical/$(LIB_PREFIX)xpical$(DLL_SUFFIX) ./xpi/components
-       cp libxpical/_xpidlgen/calendar.xpt ./xpi/components
+       cp base/build/calbscmp$(DLL_SUFFIX) ./xpi/components
+       cp base/public/_xpidlgen/*.xpt ./xpi/components
        cp $(srcdir)/resources/content/calendarService.js ./xpi/components
        cp $(DEPTH)/dist/bin/chrome/calendar-*.jar ./xpi/chrome

it copies (all?) the files that a normal build with --enable-calendar also
copies to components, and I can then produce an XPI. Of course with the current
state (bug 283316) this XPI is pretty useless.

Comment 2

[Michiel van Leeuwen (email: mvl+moz@)]

marking as regression. The summary isn't, but the result (not being able to
create an xpi) is a regression

Comment 3

[Michiel van Leeuwen (email: mvl+moz@)]

The patch from comment 1 doesn't copy all the javascript components into the
xpi, so it won't work.

Comment 4

[Michiel van Leeuwen (email: mvl+moz@)]

bug 296390 is now for building an xpi. xpical is not build for a while now.
closing this.

Comment 5

[Reed Loden [:reed]]

The bugspam monkeys have been set free and are feeding on Calendar :: Sunbird Only. Be afraid for your sanity!