Closed Bug 283318 Opened 20 years ago Closed 19 years ago

Errors in mail_help.xhtml

Categories

(SeaMonkey :: Help Documentation, defect)

x86
Windows 2000
defect
Not set
trivial

Tracking

(Not tracked)

RESOLVED FIXED
seamonkey1.0beta

People

(Reporter: unghost, Unassigned)

Details

(Keywords: fixed1.8)

Attachments

(1 file, 1 obsolete file)

User-Agent:       Mozilla/5.0 (Windows; U; Windows NT 5.0; ru-RU; rv:1.7.5) Gecko/20041107 Firefox/1.0
Build Identifier: Mozilla/5.0 (Windows; U; Windows NT 5.0; ru-RU; rv:1.7.5) Gecko/20041107 Firefox/1.0

http://lxr.mozilla.org/mozilla/source/extensions/help/resources/locale/en-US/mail_help.xhtml#2081

<p><strong>Tip</strong>: Communicator address book files (pab.na2) are stored in
your user profile directory (for example, C:\Program
Files\&brandShortName;\Users, where \Users contains the user profiles
directories).</p>

I guess that Netscape Communicator is usually installed in C:\Program
Files\Netscape\, not C:\Program Files\Mozilla\

http://lxr.mozilla.org/mozilla/source/extensions/help/resources/locale/en-US/mail_help.xhtml#2095

You can export an address book to one of these file formats: &brandShortName; 
(.ldif), tab-delimited (.tab), comma-separated (.csv), or text (.txt) formats.</p>

What is &brandShortName; (.ldif) format?

Reproducible: Always
(In reply to comment #0)

> <p><strong>Tip</strong>: Communicator address book files (pab.na2) are stored in
> your user profile directory (for example, C:\Program
> Files\&brandShortName;\Users, where \Users contains the user profiles
> directories).</p>
> 
> I guess that Netscape Communicator is usually installed in C:\Program
> Files\Netscape\, not C:\Program Files\Mozilla\
> 

Yes but &brandShortname; is an entity. So a vendor like Netscape will substitute
"Mozilla" with "Netscape" in
http://lxr.mozilla.org/seamonkey/source/xpfe/global/resources/locale/en-US/brand.dtd.
Netscape users will then get the right path.

> What is &brandShortName; (.ldif) format?

If you're using Mozilla, that would be Mozilla (.ldif) format.

Please resolve as invalid if those were the errors you wanted to report.

Thanks
(In reply to comment #1)
> (In reply to comment #0)
> 
> > <p><strong>Tip</strong>: Communicator address book files (pab.na2) are stored in
> > your user profile directory (for example, C:\Program
> > Files\&brandShortName;\Users, where \Users contains the user profiles
> > directories).</p>
> > 
> > I guess that Netscape Communicator is usually installed in C:\Program
> > Files\Netscape\, not C:\Program Files\Mozilla\
> > 
> 
> Yes but &brandShortname; is an entity. So a vendor like Netscape will substitute
> "Mozilla" with "Netscape" in
>
http://lxr.mozilla.org/seamonkey/source/xpfe/global/resources/locale/en-US/brand.dtd.
> Netscape users will then get the right path.
> 

May be Netscape users will get right path, but Mozilla Suite users are got wrong
path.
Here comes cut&paste from Mozilla Suite Help:
-----------------------------------------------
Tip: Communicator address book files (pab.na2)
are stored in your user profile directory (for example, C:\Program
Files\Mozilla\Users, where \Users contains the user profiles
directories).
----------------------------------------------

> > What is &brandShortName; (.ldif) format?
> 
> If you're using Mozilla, that would be Mozilla (.ldif) format.
> 

LDIF is not format invented by Mozilla, I guess. Right now is sounds like
proprietary Mozilla format. I think that phrase should sound like:

You can export an address book to one of these file formats: LDIF 
(.ldif), tab-delimited (.tab), comma-separated (.csv), or text (.txt) formats

> Here comes cut&paste from Mozilla Suite Help:
> -----------------------------------------------
> Tip: Communicator address book files (pab.na2)
> are stored in your user profile directory (for example, C:\Program
> Files\Mozilla\Users, where \Users contains the user profiles
> directories).
> ----------------------------------------------

Aha, you mean that the path 'C:\Program Files\Mozilla\Users'is wrong (I'm on a
mac). Wouldn't this require a lot of different paths depending on what windows
version/log-in/not log-in a user has? Also, paths differ according to OS
(mac/win/*nix).

> LDIF is not format invented by Mozilla, I guess. Right now is sounds like
> proprietary Mozilla format. I think that phrase should sound like:
> 
> You can export an address book to one of these file formats: LDIF 
> (.ldif), tab-delimited (.tab), comma-separated (.csv), or text (.txt) formats
> 

Makes sence, hmm we should probably explain LDIF in a simple way... 

(In reply to comment #3)
> > Here comes cut&paste from Mozilla Suite Help:
> > -----------------------------------------------
> > Tip: Communicator address book files (pab.na2)
> > are stored in your user profile directory (for example, C:\Program
> > Files\Mozilla\Users, where \Users contains the user profiles
> > directories).
> > ----------------------------------------------
> 
> Aha, you mean that the path 'C:\Program Files\Mozilla\Users'is wrong (I'm on a
> mac). Wouldn't this require a lot of different paths depending on what windows
> version/log-in/not log-in a user has? Also, paths differ according to OS
> (mac/win/*nix).
> 

That's just example. On Windows Netscape are usually installed in C:\Program
Files\Netscape\. All that should be done is to replace C:\Program
Files\&brandShortName;\Users with C:\Program Files\Netscape\Users

I can make a patch, if you want.

> That's just example. On Windows Netscape are usually installed in C:\Program
> Files\Netscape\. All that should be done is to replace C:\Program
> Files\&brandShortName;\Users with C:\Program Files\Netscape\Users

OK, so the point is that for Netscape users the path is correct. But not for
mozilla users? Hmm, Ian - what do you think? I must say I would prefer that we
gave the correct Mozilla path and not the Netscape one... ;)


Perhaps the path can be made an entity? And somehow be created when
Firefox/Mozilla/Netscape is installed.
(In reply to comment #6)
> Perhaps the path can be made an entity? And somehow be created when
> Firefox/Mozilla/Netscape is installed.

We could do that. Any distributor could then change the path. We still have the
problem that paths are different between platforms/systems, though.
Well, isn't there an option to make a platform specific entity?
Attached patch Fix for a few errors. (obsolete) — Splinter Review
Since this bug has been somewhat fixed (by removing nab2 import which is not available in SM), I will reuse this nice summary for fixing other bugs! :)
Included in the patch is also the fix for bug 314966: please forget about it, but check carefully the rest.
Attachment #205230 - Flags: review?(iann_bugzilla)
Comment on attachment 205230 [details] [diff] [review]
Fix for a few errors.

>Index: extensions/help/resources/locale/en-US/mail_help.xhtml
>===================================================================
>   <li><strong>Spellcheck As You Type:</strong> Choose this option to have the
>     spelling of the message text checked as you type.</li>
>+  <li><strong>Quote Message:</strong> Choose this option to have the
>+    selection of the message text shown as quoted text.</li>
"selection" could go on the previous line here, r= with that change.
Attachment #205230 - Flags: review?(iann_bugzilla) → review+
Giacomo, all this stuff is also good for branch, right?
(In reply to comment #11)
> Giacomo, all this stuff is also good for branch, right?

Very good, actually. It makes the docs for mailnews less uncomplete... ;)
Attachment #205230 - Attachment is obsolete: true
Comment on attachment 205345 [details] [diff] [review]
Updated per comments and checkins... ;) (Checked into trunk/branch)

Carrying over r+, waiting for checkin.
Attachment #205345 - Flags: review+
Comment on attachment 205345 [details] [diff] [review]
Updated per comments and checkins... ;) (Checked into trunk/branch)

Checking in
mail_help.xhtml;
new revision: 1.66; previous revision: 1.65
done
Attachment #205345 - Attachment description: Updated per comments and checkins... ;) → Updated per comments and checkins... ;) (Checked into trunk)
--> Fixed
Status: NEW → RESOLVED
Closed: 19 years ago
Resolution: --- → FIXED
Comment on attachment 205345 [details] [diff] [review]
Updated per comments and checkins... ;) (Checked into trunk/branch)

Low-risk, SeaMonkey Help only...
Attachment #205345 - Flags: approval1.8.0.1?
Whiteboard: Fixed on trunk
Moving to suite component in order to set flag...
Component: Help Viewer → Help
Product: Documentation → Mozilla Application Suite
Target Milestone: --- → seamonkey1.0beta
Comment on attachment 205345 [details] [diff] [review]
Updated per comments and checkins... ;) (Checked into trunk/branch)

Low-risk, SeaMonkey Help...
Attachment #205345 - Flags: approval1.8.0.1? → approval-seamonkey1.0?
Comment on attachment 205345 [details] [diff] [review]
Updated per comments and checkins... ;) (Checked into trunk/branch)

a=me, just need one more now...
Attachment #205345 - Flags: approval-seamonkey1.0? → approval-seamonkey1.0+
Keywords: fixed1.8
Whiteboard: Fixed on trunk
Attachment #205345 - Attachment description: Updated per comments and checkins... ;) (Checked into trunk) → Updated per comments and checkins... ;) (Checked into trunk/branch)
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: