283341 - [devmo] under this directory, history and Edit link are broken.

Status: RESOLVED FIXED

(www.mozilla.org :: General, defect)

Description

[victory <[e-mail]>]

User-Agent:       Mozilla/5.0 (Windows; U; Windows NT 5.0; ja-JP; rv:1.7.5) Gecko/20041108 Firefox/1.0
Build Identifier: -

under http://developer.mozilla.org/xpcom/api/, 
history and Edit link are broken because those sources are xml and they point html.

Reproducible: Always

Steps to Reproduce:

Comment 1

[victory <[e-mail]>]

Attachment: under http://developer.mozilla.org/xpcom/api/ , point xml files

Comment 2

[fantasai]

Comment on attachment 175331 [details] [diff] [review]
under http://developer.mozilla.org/xpcom/api/ , point xml files

Change the variable 'history' to 'sourcefile' and indent that line so it's more
readable. E.g.

[%- sourcefile = 
      IF (matches = template.name.match('^xpcom/api/(\w+).html$')); THEN;
	"xpcom/api/"; matches.0; ".xml";
      ELSE;
	template.name; END; -%]

Comment 3

[victory <[e-mail]>]

Attachment: apply fantasai's comment

Comment 4

[victory <[e-mail]>]

commited. Thanks to jwatt for report :)

Comment 5

[victory <[e-mail]>]

Attachment: 175334 didn't fix subdirectory

175334 fix only xpcom/api, not recursive.
add urlencode of '+'

Comment 6

[fantasai]

Comment on attachment 176881 [details] [diff] [review]
175334 didn't fix subdirectory

The first two lines seem fine. I don't know what the second two lines are
trying to fix. Filenames shouldn't have whitespace in any case.

Comment 7

[victory <[e-mail]>]

not whitespace.
some file such as http://developer.mozilla.org/xpcom/api/nsACString/operator+=
 includes '+' char, that must be escaped.

Comment 8

[fantasai]

Comment on attachment 176881 [details] [diff] [review]
175334 didn't fix subdirectory

>-      [%- sourcefile = 
>+      [%- sourcefile_ = 

There is no need to change the name of this variable.

>+        END; -%][%- sourcefile = 

The - next to the % is supposed to trim whitespace, so
you do not need to break the indentation like this. The
END should stay where it was, and the new directive should
start on a new line, just like the previous one.

>+        IF (matches = sourcefile_.match('(.*)\+(.*)'));

You should probably use the .replace method instead of
writing your own.

Also, while we're at it, let's %escape '=' and '&', too.

Comment 9

[victory <[e-mail]>]

Attachment: using replace()

actually, tt pulls those value asis and does almost same though.

Comment 10

[victory <[e-mail]>]

commited.