283383 - Create JSS and JSSE client/server test programs that intercommunicates to validate ciphers

Status: RESOLVED FIXED

(JSS Graveyard :: Tests, enhancement)

Description

[Sandeep Konchady]

User-Agent:       Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.7.3) Gecko/20040910
Build Identifier: Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.7.3) Gecko/20040910

Create a set of client and server tests for JSS and JSSE (JDK 1.4.0) such that
JSS clients communicates with JSSE server and JSSE client communicates with JSS
server to validate ciphers supported by both.  This test encompasses the following

[1] Enables all server and client implemented ciphers in JSS and JSSE
[2] Tests for common ciphers between JSS and JSSE


Reproducible: Always

Comment 1

[Wan-Teh Chang]

This is a great idea.  We've wanted to do this
in NSS.

Comment 2

[Sandeep Konchady]

Attachment: cvs diff patch listing for 283383 with 7 new java files, 2 shell scripts and modified all.pl

Files List : cvs diff patch listing for 283383

A ClassServer.java
A Constants.java
A GenerateTestCert.java
A JSSE_SSLClient.java
A JSSE_SSLServer.java
A JSS_SSLClient.java
A JSS_SSLServer.java
M all.pl
A startJssServ.sh
A startJsseServ.sh

Comment 3

[Wan-Teh Chang]

Comment on attachment 178322 [details] [diff] [review]
cvs diff patch listing for 283383 with 7 new java files, 2 shell scripts and modified all.pl

Sandeep: sorry, I should have been more clear
in the instructions I sent to you by email.

When generating a patch, always pass the -u option
to "cvs diff".	The -u option generates "unified"
diffs, which contain some context near the modified
code.

If you add new files, then you also need to pass
the -N option to "cvs diff".

So please regenerate the patch using "cvs diff -uN".
Thanks.

Comment 4

[Sandeep Konchady]

Attachment: cvs diff patch listing for 283383 with 7 new java files, 2 shell scripts and modified all.pl

Files List : cvs diff patch listing for 283383

A ClassServer.java
A Constants.java
A GenerateTestCert.java
A JSSE_SSLClient.java
A JSSE_SSLServer.java
A JSS_SSLClient.java
A JSS_SSLServer.java
M all.pl
A startJssServ.sh
A startJsseServ.sh

Comment 5

[Christophe Ravel]

Attachment: Fix issue with testing optimized version

Wrong jar file was taken for test with BUILD_OPT=1

Comment 6

[Christophe Ravel]

Attachment: Fix issue with JSSE test for 64 bit version

Java path and options are passed from all.pl to startJssServ.sh and
startJsseServ.sh.

(committed).

Comment 7

[Sandeep Konchady]

Attachment: Fix for JSS and JSSE server to timeout on no client request

The two servers did not have a mechanism to timeout if they received no client
request.  This left the server programs hanging on some systems.  Added a
timeout mechanism which will exit the program in 120 sec (2 min).

Comment 8

[Saul Edwards]

Comment on attachment 180403 [details] [diff] [review]
Fix for JSS and JSSE server to timeout on no client request

If your indentation is actually correct and diff is misprinting it, please use
the -t option in your diffs.  Otherwise, please fix the indentation. 
Everything else AOK.

Comment 9

[Sandeep Konchady]

Attachment: Fix for JSSE and JSS client timeout issue

Fixed a couple of issues.
[1] Reduced JSS and JSSE server timeout from 2 min to 35 sec
[2] Added try/catch to JSSE client to detect non Sun JCA
[3] Added socket and program timeout for JSS and JSSE clients so that they exit
gracefully

Comment 10

[Saul Edwards]

Comment on attachment 181597 [details] [diff] [review]
Fix for JSSE and JSS client timeout issue

Making a function in the JSSE_SSL client would make it a lot easier to read -
those three sets of code only differ by the array of ciphers they are testing,
right?	Otherwise, everything looks good.

Comment 11

[glen beasley]

Comment on attachment 181597 [details] [diff] [review]
Fix for JSSE and JSS client timeout issue

looks okay.

Comment 12

[Wan-Teh Chang]

Sandeep, could you set the target milestone (the first
JSS version this fix will appear in)?  Thanks.