283466 - "Malformed Registration Error" (in extension installation) should specify extension

Status: RESOLVED DUPLICATE of bug 290021

(Toolkit :: Add-ons Manager, defect)

Description

[Jussi Kukkonen]

Since multiple extensions can be installed at the same time (and will be
installed, because of automatic updates), the "Malformed Registration Error"
should specify which extension is the culprit - finding that information from
the JS Console is too much to ask from a normal user. The code lives in
http://lxr.mozilla.org/mozilla/source/toolkit/mozapps/extensions/src/nsExtensionManager.js.in#489

I am not sure how to reproduce this, but this is what happened to me:
I had Firefox 1.0.1 with Flashblock and a bunch of other extensions installed.
Then, the green automatic-update button appeared and I let it do the magic,
updating three extensions (Flashblock, miniT(drag) and JSLib, IIRC). On restart
I got the "finishing extension installation..."-window and "Malformed
Registration Error"-prompt. The error didn't specify which extension failed, but
I presed "View Details", and saw this in JS Console:

---
Chrome Registration failed for Extension
'{3d7eb24f-2740-49df-8937-200b1cc08f8a}' when calling
nsIXULChromeRegistry::installLocale with this chrome path:
jar:file:///C:/Documents%20and%20Settings/Administrator/Application%20Data/Mozilla/Firefox/Profiles/103v7itk.Jussi/extensions/%7B3d7eb24f-2740-49df-8937-200b1cc08f8a%7D/chrome/flashblock.jar!/locale/hu-HU/flashblock/
(profile extension = true). Perhaps this path does not exist within the chrome
JAR file, or the contents.rdf file at that location is malformed?
---

This is what the prompt looked like:
"Firefox could not install this item because of a failure in Chrome
Registration. Please contact the author about this problem, or click View
Details for more information."

This is what I 'expected' to see:
"Firefox could not install 'Flashblock' because of a failure in Chrome
Registration. Please contact the author about this problem, or click View
Details for more information."

Comment 1

[Jussi Kukkonen]

Sorry for bugspam, forgot the exact version info:

Mozilla/5.0 (Windows; U; Windows NT 5.0; en-US; rv:1.7.6) Gecko/20050223
Firefox/1.0.1

Comment 2

[Philip Chee]

Attachment: Flashblock install log with chrome registry errors

Flashblock users have been complaining to us about chrome registration errors
with both Mozilla suite (install.js) and Firefox (install.rdf).

These problems only happen if there is a version of flashblock all ready
installed in the profile you are installing to.  Our current workaround is to
uninstall the existing version first.

<http://flashblock.mozdev.org/problems.html>

There appear to be two problems: Registering the content, and registering the
locale.  I'm just guessing wildly but I think there is a race condition between
copying the .jar file into the profile and doing the registration.

For example, if I install the same version over the existing version, I do not
get chrome registry errors when registering locales.  However if I add a locale
to be registered in the install.js script, this is what I get: (see attachment)


The chrome registration fails with the new locale that was not in the previous
.jar file.  In this case it was the es-ES locale

The above is for Mozilla.  For firefox, even when there are chrome registry
errors, the install.log just says:

-------------------------------------------------------------------------------

file:///C:/TEMP/flashblock-test.xpi  --  2005-02-24 20:18:40
-------------------------------------------------------------------------------


     Install completed successfully  --  2005-02-24 20:18:40

but Flashblock dissappears from the list of extensions in the extensions
manager.

[e-mail]
http://flashblock.mozdev.org/

Comment 3

[Philip Chee]

Um I meant to post this to bug id 281962
Sorry

Comment 4

[wessonjoe]

Chrome Registration failed for Extension
'{3d7eb24f-2740-49df-8937-200b1cc08f8a}' when calling
nsIXULChromeRegistry::installPackage with this chrome path:
jar:file:///C:/Documents%20and%20Settings/Administrator.WESSON-FOOZ65QH/Application%20Data/Mozilla/Firefox/Profiles/7unsw91d.default/extensions/%7B3d7eb24f-2740-49df-8937-200b1cc08f8a%7D/chrome/flashblock.jar!/content/flashblock/
(profile extension = true). Perhaps this path does not exist within the chrome
JAR file, or the contents.rdf file at that location is malformed?

Mozilla/5.0 (Windows; U; Windows NT 5.0; en-US; rv:1.7.8) Gecko/20050511
Firefox/1.0.4

Comment 5

[Robert Strong (they/them - no direct email)]

With the chrome registry re-write that was done several months ago and is part of 1.5 this error should now only be seen by extension developers.

Comment 6

[Robert Strong (they/them - no direct email)]

Bug 290021 covers adding the name to the error message - though I doubt that is possible as noted in that bug. Otherwise, this should be fixed due to the chrome registry re-write as noted in comment #5. Marking duplicate of bug 290021.

*** This bug has been marked as a duplicate of 290021 ***